From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from antelope.elm.relay.mailchannels.net (antelope.elm.relay.mailchannels.net [23.83.212.4]) by sourceware.org (Postfix) with ESMTPS id 885C43858C52 for ; Wed, 4 Oct 2023 11:59:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 885C43858C52 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=sourceware.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 3EFDA1423E1; Wed, 4 Oct 2023 11:59:25 +0000 (UTC) Received: from pdx1-sub0-mail-a234.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A26C6142307; Wed, 4 Oct 2023 11:59:24 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696420764; a=rsa-sha256; cv=none; b=1I8nvq3XBtOOYp1zQFkFUiQ0gethbTgGAScNh3+ETEpHIM+gIFpS1WjupljjPMoH2mBdr7 aCTdgl47uTOE1yZ7CEd4TmSjPlK04t9mfFWdjziTNvkbzUqAI0XMT+tLf071U1IY8rUkZt A8WAhNmNCZqtYuKf9wMNMIzahWN/GEFhI/IXkmqHwgGGOr+gb6FU4D3GciYqUVAtjvT0hF fqiL7rZEvCtpwJ81K7g0Zugfei5jdvViFUxH2+/FE1qBeLvF+FNc7GNeCNqQf4CNdphYgr N2UajnTnJbH3Lf4R6EPzYF2igYc/fgg/jrOCaYKpXLMzc59/CmYgoR5ZbGP57g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696420764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jtow/87cDMxpNwmbxZCJtJbmK4qGQxaFHtokpgTBICU=; b=82cz8ZPCSgAvLGigTwW7nIhbUP/a7oKtseWxKvzx4bhuaGRmwL6BaAGq8bPNUuhGQFRzwz D9yCMXwdKeNvc8FPAUJstxWD0Z9CDONGr/Iw+FIoQP7NVkqh4f27QNhhlZCmemFSGwso8H IUiELQfWq4SFE3J1iJ0Sbrtum0K2gwPpyQ2kPOhJzVWqmMdUChJxgCB7WjtSMex31Cykxm TXM+BEV29klw0nQ7wsnBNH1Acb7V0QHdHdtgx9555LLPTH7Mkzj2GH/7BqpgZWcjdXkmO3 QlNOeFoNmYp0nAsXUpDIVTfCxtWa1F9ZE0hXcGwv6zX+9nZ9vzQRCH4NVAN8ng== ARC-Authentication-Results: i=1; rspamd-7c449d4847-7bf98; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MC-Copy: stored-urls X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Vacuous-Wipe: 6659317c355814c3_1696420764925_3542818840 X-MC-Loop-Signature: 1696420764925:799567463 X-MC-Ingress-Time: 1696420764924 Received: from pdx1-sub0-mail-a234.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.162.150 (trex/6.9.1); Wed, 04 Oct 2023 11:59:24 +0000 Received: from [192.168.2.12] (bras-vprn-toroon4834w-lp130-02-142-113-138-41.dsl.bell.ca [142.113.138.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a234.dreamhost.com (Postfix) with ESMTPSA id 4S0tXD0p6xz6g; Wed, 4 Oct 2023 04:59:24 -0700 (PDT) Message-ID: Date: Wed, 4 Oct 2023 07:59:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] aarch64: Make glibc.mem.tagging SXID_ERASE Content-Language: en-US To: Szabolcs Nagy , libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, fweimer@redhat.com, carlos@redhat.com References: From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1167.1 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-04 03:29, Szabolcs Nagy wrote: > The 10/03/2023 16:11, Siddhesh Poyarekar wrote: >> Limit effect of memory tagging to the same process and don't let it >> bleed across privilege boundaries into non-setuid children of setuid >> processes. >> >> Signed-off-by: Siddhesh Poyarekar > > the description does not match the documented behaviour of > SXID_IGNORE. (the setuid binary passes on the setting from > its parent, i don't see the privilege boundary crossing) Maybe "privilege boundary crossing" is too strong a phrase, how about "bleed across different users or groups"? > and it does not explain why would you want to turn a security > hardening feature off. > > i'm not against the patch as the heap tagging feature is > very experimental at this point, but it needs a better > explanation. How about: """ Memory tagging is still an experimental feature, so limit propagation of tunables across setxid binaries. """ In future though, would you want SXID_IGNORE for memory tagging? I would expect that once memory tagging becomes a stable feature you'd want it to be enabled by default and disabled by, e.g. a systemwide tunable. I can't see why you'd want it to go across the setxid boundary. Thanks, Sid