From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from duck.ash.relay.mailchannels.net (duck.ash.relay.mailchannels.net [23.83.222.52]) by sourceware.org (Postfix) with ESMTPS id D807F3858D20 for ; Thu, 14 Sep 2023 10:24:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D807F3858D20 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=sourceware.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 255A7C203C; Thu, 14 Sep 2023 10:24:30 +0000 (UTC) Received: from pdx1-sub0-mail-a209.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B52EEC2114; Thu, 14 Sep 2023 10:24:29 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1694687069; a=rsa-sha256; cv=none; b=mOZIrxODlvQNEMx9K7xMFZY1AXnUsCU9qBvPrrwLcP3GBK5EuIu0YyoG6yhUHPQ2sCzQih HgJ3pCBrtoO3SEiVTGSNL54eZASztyHZmiZHe8p/MfKACYUCfn4m9C6ZLt1kJA1uyUJyK+ WYeRRIP8KvHmyX8SDnAQExpt9JwpNcyRgSWNMBFRHtQ/e9zeG3oJhGBDCkt/CsBHGbSjV6 NKBL9MkYTrG5we++u4W66TAPRHHtjK2Kbmph+lOryikcyaZZcuNtm2t3opT3dWBLjIrV/y N0LKiKoprahmP1WN6d8AOMDdXRTj6Ohu0EQDPaKCslgPXPySn4Iml9Iwe+lSmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1694687069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pbmuNMQ6tj2MEO7tpJJwTDCPq7fl22J352cVS4TYo9A=; b=hOKlWSMPt1ckBSztRWhsFIUFNjkgsS3r7NSxBtk448absD/YE/PEniHlI1HkdKQTWh/vis 0dXeXMfU7ngfAhEB6zehfG0gCWRZzyEcR1yGvKtdXTvVsT9CHiIAUGsZ0DVdtNj1WFazRH vuJy89bAy+/vpELhKDPwDVHWTo8hhr9rQ5xfXViSv8zhr3+XfrghPRDLvvPaQXUmRsovA8 kbt1tIm64h5gSrZuEHPnbrxbrPQE+Wy+LTqOGc0BzkmSpYnN01mH1GFg+f5iQne1wxeiYl vhgjNpHRXqiGkUnQQjlwJCrh5jQsLDJeCmmBynVWaikIsB3M+0MlYAT9TCrH3g== ARC-Authentication-Results: i=1; rspamd-7d5dc8fd68-nkvsj; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Illegal-Bottle: 2640cc8a20d51ca3_1694687069985_545159666 X-MC-Loop-Signature: 1694687069985:3846425838 X-MC-Ingress-Time: 1694687069985 Received: from pdx1-sub0-mail-a209.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.99.54.176 (trex/6.9.1); Thu, 14 Sep 2023 10:24:29 +0000 Received: from [192.168.0.182] (unknown [142.113.138.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a209.dreamhost.com (Postfix) with ESMTPSA id 4RmYMx23q9zBX; Thu, 14 Sep 2023 03:24:29 -0700 (PDT) Message-ID: Date: Thu, 14 Sep 2023 06:24:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] getaddrinfo: Fix use after free in getcanonname (CVE-2023-4806) Content-Language: en-US To: Andreas Schwab Cc: libc-alpha@sourceware.org, fweimer@redhat.com, carlos@redhat.com References: <20230913173638.3067388-1-siddhesh@sourceware.org> <20230913205628.3113433-1-siddhesh@sourceware.org> <0a0bc1d3-49a3-b78b-b357-4eea236e25dc@sourceware.org> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1166.3 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-09-14 06:12, Andreas Schwab wrote: > On Sep 14 2023, Siddhesh Poyarekar wrote: > >> AFAICT, all container tests run as root within the container. > > That's not what test-container implies, AFAICS. > >> I can add su in the script file to make it explicit, > > Why would that option exist if it is a no-op? > OK, so what seems to be happening here is that files in the container (at least the few I've tested right now) are owned by the executing user, so there's actually no need to run as root to modify them, which explains why the test works. I've sent v3 anyway to make it kosher in case we end up fixing this in future. Thanks, Sid