From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30794 invoked by alias); 10 Sep 2018 12:01:28 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 30779 invoked by uid 89); 10 Sep 2018 12:01:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:525, strcmp, HContent-Transfer-Encoding:8bit X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH] Adjust name-prefix of ld.so in test-container.c. To: libc-alpha@sourceware.org References: From: Stefan Liebler Date: Mon, 10 Sep 2018 12:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit x-cbid: 18091012-0012-0000-0000-000002A69B8E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18091012-0013-0000-0000-000020DAD364 Message-Id: X-SW-Source: 2018-09/txt/msg00095.txt.bz2 On 09/05/2018 11:14 AM, Stefan Liebler wrote: > On 09/04/2018 06:37 PM, DJ Delorie wrote: >> >> Stefan Liebler writes: >>> +  if (strncmp (argv[1], support_objdir_elf_ldso, >>> +           strlen (support_objdir_elf_ldso)) == 0) >> >> If we're comparing the whole name now, this could be a strcmp() instead? >> > Yes, of course. You are right. > I've updated the patch. > > Thanks > Stefan PING Is this okay to commit? Bye Stefan