From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-83310-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 38278 invoked by alias); 17 Aug 2017 07:44:53 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 37332 invoked by uid 89); 17 Aug 2017 07:44:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 51C0B63746
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer@redhat.com
Subject: Re: [PATCH] Test for profiling support (_mcount/gprof)
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>, GNU C Library <libc-alpha@sourceware.org>
References: <4d15086e-9e54-014b-1a50-16534f287e24@redhat.com>
 <mvm4lt9ui9h.fsf@suse.de> <539fb6f1-9d96-01d5-0f35-f3c312c0ecbb@redhat.com>
 <mvmshgtt2fd.fsf@suse.de> <87b76487-16d3-78b4-9651-f6d375b9b137@redhat.com>
 <mvma830t3id.fsf@suse.de> <36b6ab73-342d-0886-8767-ff7fd6dd4d79@redhat.com>
 <mvm1soct0tx.fsf@suse.de> <907f751a-3916-64c9-f650-df182fb3cdce@redhat.com>
 <mvm7ey3sgbx.fsf@suse.de> <93df1f7c-b5f9-4ab7-5fe8-87baf94e4d34@redhat.com>
 <mvm378rsfnj.fsf@suse.de> <40ca3281-c22c-954d-b11d-5312782971e3@redhat.com>
 <mvmy3qjr0m2.fsf@suse.de> <357353c9-2633-a1a5-4d78-49862087a8a5@redhat.com>
 <CAMe9rOpbNU0eaMHV8w1QFfoVdU6vLHayVhOdgwwoMzK2bJb00w@mail.gmail.com>
 <c1240ceb-d418-e7a2-3d74-74cc0a800ac6@redhat.com>
 <CAMe9rOpaoLrx6Wg1R1v0038Lbo0e2exy-yVCRdSYQrrYKqtGeQ@mail.gmail.com>
 <CAMe9rOpye5pUs1j_V_ANOJQfrzK5VXhacLhHFzB95OD+3dtSPw@mail.gmail.com>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <f6f67df9-501b-ca3c-429a-49162491013d@redhat.com>
Date: Thu, 17 Aug 2017 07:44:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CAMe9rOpye5pUs1j_V_ANOJQfrzK5VXhacLhHFzB95OD+3dtSPw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-08/txt/msg00726.txt.bz2

On 08/16/2017 11:19 PM, H.J. Lu wrote:
> -pg and -pie are mutually exclusive since they need different crt1.o,
> gcrrt1.o vs Scrt1.o.  Make -pg overrdies -pie.
> 
> 	* Makeconfig (+link-pie-before-libc): Add CRT-* hook to override
> 	the startup object.

Typo (gcrrt1.o), and the commit message is confusing.  There is no -pg
involved at the linking stage.

gcrt1.o is deliberately compiled so that it is compatible with PIE, so
the patch itself is okay.

Thanks,
Florian