From: Florian Weimer <fweimer@redhat.com>
To: Zack Weinberg <zackw@panix.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>
Date: Thu, 28 Jun 2018 10:52:00 -0000 [thread overview]
Message-ID: <f7156490-61fd-78b9-993d-fe00762cf8a9@redhat.com> (raw)
In-Reply-To: <20180628095209.GA10666@altlinux.org>
On 06/28/2018 11:52 AM, Dmitry V. Levin wrote:
> On Thu, Jun 28, 2018 at 10:27:53AM +0200, Florian Weimer wrote:
>> On 06/21/2018 01:24 PM, Florian Weimer wrote:
>>> diff --git a/time/bits/types/struct_timespec.h b/time/bits/types/struct_timespec.h
>>> index 644db9fdb6..5b77c52b4f 100644
>>> --- a/time/bits/types/struct_timespec.h
>>> +++ b/time/bits/types/struct_timespec.h
>>> @@ -1,5 +1,6 @@
>>> -#ifndef __timespec_defined
>>> -#define __timespec_defined 1
>>> +/* NB: Include guard matches what <linux/time.h> uses. */
>>> +#ifndef _STRUCT_TIMESPEC
>>> +#define _STRUCT_TIMESPEC 1
>>
>> Are there any objections to this change? It's required to fix a GCC
>> build failure, so I'm going to commit this soon (probably on Friday).
>
> The change looks fine, thanks.
Thanks. I filed bug 23349 to track this and will reference it in the
commit.
Florian
prev parent reply other threads:[~2018-06-28 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 6:47 Florian Weimer
2018-06-21 11:01 ` Zack Weinberg
2018-06-21 11:24 ` Florian Weimer
2018-06-26 17:03 ` Florian Weimer
2018-06-28 8:28 ` Florian Weimer
2018-06-28 9:52 ` Dmitry V. Levin
2018-06-28 10:52 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7156490-61fd-78b9-993d-fe00762cf8a9@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).