From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-97269-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 25975 invoked by alias); 15 Nov 2018 17:23:32 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 25963 invoked by uid 89); 15 Nov 2018 17:23:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=1.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SEM_URI,SEM_URIRED,SPF_PASS autolearn=no version=3.3.2 spammy=HTo:U*gabriel, Hx-languages-length:1075, Hx-spam-relays-external:209.85.215.196, H*RU:209.85.215.196
X-HELO: mail-pg1-f196.google.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=IgciOoT6Jm+mPFXPytOZ95KWOJqoNu3UAvxSWQEniHA=;
        b=Thk95vCc9zCLEDNlYd8KZERnP0sPKVPBfbE2wHOJWGEdpM4WjzBw79MJtUgXY+nbYZ
         b7XhNLizvjh4mszZYqrgB2T67peheTIGjKxKF8Fg0uk9yRMHDyib2IpA3xImIvv/ddHS
         z03ddBANEWFSbozru+U5IiVFedGPoImZXyH+E=
Return-Path: <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH v2 1/8] Use STRFMON_LDBL_IS_DBL instead of __ldbl_is_dbl.
To: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br>
Cc: libc-alpha@sourceware.org
References: <20181029121650.24544-1-gabriel@inconstante.eti.br>
 <20181029121650.24544-2-gabriel@inconstante.eti.br>
 <e05dea4a-762f-9bd7-75bf-391608e19566@linaro.org>
 <20181113160822.6df967bb@tereshkova.br.ibm.com>
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Openpgp: preference=signencrypt
Message-ID: <f7b93e71-8204-3042-e331-7dcbfe51f8a2@linaro.org>
Date: Thu, 15 Nov 2018 17:23:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181113160822.6df967bb@tereshkova.br.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-11/txt/msg00388.txt.bz2



On 13/11/2018 10:08, Gabriel F. T. Gomes wrote:
> On Wed, 07 Nov 2018, Adhemerval Zanella wrote:
>> On 29/10/2018 09:16, Gabriel F. T. Gomes wrote:
>>> From: Zack Weinberg <zackw@panix.com>
>>>
>>> +extern ssize_t
>>> +__vstrfmon_l_internal (char *s, size_t maxsize, locale_t loc,
>>> +		       const char *format, va_list ap,
>>> +		       unsigned int flags)
>>> +  attribute_hidden;
>>> +
>>> +/* Flags for __vstrfmon_l_internal.  */
>>> +#define STRFMON_LDBL_IS_DBL 0x0001  
>>
>> Please extend the flag comment to describe what it does.
> 
> With the proposed text (below) and DCO's signed-off-by statements removed
> from the commit message, is it OK for master?
> 
> +/* Flags for __vstrfmon_l_internal.
> +
> +   STRFMON_LDBL_IS_DBL is a one-bit mask for the flags parameter that
> +   indicates whether long double values are to be handled as having the
> +   same format as double, in which case the flag should be set to one,
> +   or as another format, otherwise.  */
> +#define STRFMON_LDBL_IS_DBL 0x0001
> 

LGTM, thanks.