From: Florian Weimer <fweimer@redhat.com>
To: "Carlos O'Donell" <carlos@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3] Add cancellation regression test for getpwuid_r.
Date: Fri, 09 Dec 2016 10:09:00 -0000 [thread overview]
Message-ID: <f7d949fd-f6d9-f40a-200f-e105c7033e34@redhat.com> (raw)
In-Reply-To: <4c7c6c97-3bf5-2c92-5e2a-70443039b3e3@redhat.com>
On 12/09/2016 01:13 AM, Carlos O'Donell wrote:
> + {
> + pthread_setcancelstate (PTHREAD_CANCEL_DISABLE, NULL);
> + /* Increase the buffer size. */
> + free (wbuf);
> + wbufsz = wbufsz * 2;
> + wbuf = xmalloc (wbufsz);
> + pthread_setcancelstate (PTHREAD_CANCEL_ENABLE, NULL);
> + }
Is it really necessary to disable cancellation around free and (x)malloc?
Our implementations really shouldn't be cancellation points, and for
free, this is rather critical.
Thanks,
Florian
next prev parent reply other threads:[~2016-12-09 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 15:42 [PATCH] Add cancellation " Carlos O'Donell
2016-12-05 15:52 ` Florian Weimer
2016-12-08 17:16 ` [PATCH v2] Add cancellation regression " Carlos O'Donell
2016-12-08 19:02 ` Mike Frysinger
2016-12-09 0:13 ` [PATCH v3] " Carlos O'Donell
2016-12-09 10:09 ` Florian Weimer [this message]
2016-12-20 20:44 ` [PATCH v4] " Carlos O'Donell
2016-12-21 13:08 ` Florian Weimer
2016-12-23 18:42 ` Carlos O'Donell
2016-12-09 19:40 ` [PATCH v3] " Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d949fd-f6d9-f40a-200f-e105c7033e34@redhat.com \
--to=fweimer@redhat.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).