From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 39A6A386587A for ; Wed, 22 May 2024 12:38:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 39A6A386587A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 39A6A386587A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716381536; cv=none; b=k+GM751mv5IwFsuebh//Z1Cty5gWxjlBRo/0q14+IajZbY9hJqVkviSH21l4rBh/4BZlhR7LxIQ8BCFgFPBqombhmayunrQRVwo9yVl1rdyfFft0cJ8lw+0kS8vLZKQSpH2/B3rurG1ykTrl2h+vmOjtFinqmNUJ457tlYm0ohs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716381536; c=relaxed/simple; bh=Tok9aYpkqCjIjoKJTXw8QUQWaFc2OCmkuE/oIOnUECU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jAoBX6BL+Er9IywNvKbA0Fc0MHaTa9t+Pl2nu0zMjCeJwA2Mjzo+ColntcA7Vcl9PoNeZEi1S0UMaHzs40y+utSB2Yx9E79JS2GvrSFwwxPrkhiLeuHGwrYE6rk5Q7/cwIepCtXUWAujw6EjV2g2+QtYUUVYJl7hu6MDCVz9VJE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1edc696df2bso10169515ad.0 for ; Wed, 22 May 2024 05:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716381531; x=1716986331; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+3fdf5vtKJn2nlzDyabDibKEpF7v3o3LQp16GVoEHpw=; b=Q98z30rFQDZl/eDvjnJbQb3ToJPL2T4JQw/vNe5GyIRLo3Udo4GjvSp+xyIR573hAv R7hcQd1AU+AFg1O1jM3YBzlm0tuY4DmcLcxQLowe2RWQ2KSrnbLd53YZ6syK+wEsGboM OwZS3K1l8rg5pQvzzj8n+hflc08AfuEAvZKHJU5atkaO03keyY3584+W5QsEvNjjLJ4H l4PF7IN04NHS7mlQNDgB6GMUtOqNC5XwfpmIrkDwhkNgIpEkMtSUoUokQMJqHf3ps6rK aw7KH8cUoeOUfxNFfOMnx+eoE4PnzXbLaIpE4hlI3EcfCVkfF84zP1JFIbpLBPPuCi2X QBMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716381531; x=1716986331; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+3fdf5vtKJn2nlzDyabDibKEpF7v3o3LQp16GVoEHpw=; b=ga9DucPOru82EMIAjrjK6NIorc2PoILGgRdEti2BCuDLg70SWb5+MxcX4jekWDfztO gZcLWgayT99fvI2Aj2lex5Il6q6Oufn6GG2nlbESbY5522N/xckGAVTfp6xp86Z9wvbc iMNmFetkQCBGu9rR04MG57LLX4IQQS91mXpd5OQdx9ZOJb8FKw+NltcaG8RRO+y2X3qr mx66ZxdFX0K9m2vrqPAvyljW6/UfgmrLjrt4GOg9/9tmiwV35L6oNQae4kSdGwJHjHU0 xHbpqADd9CjQo9l/nHvS1id64I4LJML1hBRSUamDhR16HoU9+O1gaorC0IkM6AY2AWMG jp8g== X-Forwarded-Encrypted: i=1; AJvYcCVeGpZtEUkl55Ad1jTEwXHEPrzFjE+2paMSBXzaDgTM+Qa6B0OZd41sRLTTlI2XPhtHF3wme/fuU5gJh3Y+5ML68UBKaFZe/0mZ X-Gm-Message-State: AOJu0YxwPwSAfqbEczlpOyK379HPC5U1LrxgqgSjo4mfL32go5ZAYo6O +1GCNaX3JF6uXB782mc3GjwwEOhNBHmmgLNo+EKDLNGCm1bqbgIWTyozUjZzsa8= X-Google-Smtp-Source: AGHT+IHZdERCiUWXv50LXvXeMgQjuwfrerDoItkoloc10YZc1/3ixwa7t2TgK8L14q3kFY7nE0IgEA== X-Received: by 2002:a17:903:a4e:b0:1e3:c5d1:2324 with SMTP id d9443c01a7336-1f31c997a8fmr14619155ad.32.1716381530826; Wed, 22 May 2024 05:38:50 -0700 (PDT) Received: from [192.168.15.31] ([189.79.30.199]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bad62fesm238476565ad.83.2024.05.22.05.38.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 05:38:50 -0700 (PDT) Message-ID: Date: Wed, 22 May 2024 09:38:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Don't provide scalb/significand _FloatN aliases [BZ #31760] To: "H.J. Lu" , libc-alpha@sourceware.org References: <20240520165636.311074-1-hjl.tools@gmail.com> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20240520165636.311074-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/05/24 13:56, H.J. Lu wrote: > scalb is a deprecated interface which was obsolescent in POSIX.1-2001, > removed in POSIX.1-2008, never made to C standard. significant was > originally from BSD and never made in any standard. Fix BZ #31760 by > not providing _FloatN aliases for them. > > Signed-off-by: H.J. Lu LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > math/s_significand_template.c | 12 ++++++++++++ > math/w_scalb_template.c | 12 ++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/math/s_significand_template.c b/math/s_significand_template.c > index a351390411..0c8a1c3d75 100644 > --- a/math/s_significand_template.c > +++ b/math/s_significand_template.c > @@ -30,4 +30,16 @@ M_DECL_FUNC (__significand) (FLOAT x) > { > return M_SUF (__ieee754_scalb) (x,(FLOAT) - M_SUF (__ilogb) (x)); > } > + > +/* Don't provide _FloatN aliases for significand which was originally > + from BSD and never made in any standard. */ > +#undef libm_alias_float_other_r > +#define libm_alias_float_other_r(from, to, r) > +#undef libm_alias_double_other_r > +#define libm_alias_double_other_r(from, to, r) > +#undef libm_alias_ldouble_other_r > +#define libm_alias_ldouble_other_r(from, to, r) > +#undef libm_alias_float128_other_r > +#define libm_alias_float128_other_r(from, to, r) > + > declare_mgen_alias (__significand, significand) > diff --git a/math/w_scalb_template.c b/math/w_scalb_template.c > index 2fd5ca1878..f9f98508e9 100644 > --- a/math/w_scalb_template.c > +++ b/math/w_scalb_template.c > @@ -52,6 +52,18 @@ FLOAT M_DECL_FUNC (__scalb) (FLOAT x, FLOAT fn) > return z; > } > > +/* Don't provide _FloatN aliases for scalb which is a deprecated interface, > + was obsolescent in POSIX.1-2001, removed in POSIX.1-2008, never made to > + C standard. */ > +#undef libm_alias_float_other_r > +#define libm_alias_float_other_r(from, to, r) > +#undef libm_alias_double_other_r > +#define libm_alias_double_other_r(from, to, r) > +#undef libm_alias_ldouble_other_r > +#define libm_alias_ldouble_other_r(from, to, r) > +#undef libm_alias_float128_other_r > +#define libm_alias_float128_other_r(from, to, r) > + > declare_mgen_alias (__scalb, scalb); > > #endif /* __USE_WRAPPER_TEMPLATE. */