From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id AADDE3858D1E for ; Tue, 20 Jun 2023 12:50:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AADDE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-38dec65ab50so3421169b6e.2 for ; Tue, 20 Jun 2023 05:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687265422; x=1689857422; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=4h+QTnlc+AjTQChb9+JgWJSHU7FUP2xrURgAQ6QWhzg=; b=OIxkIRCWt15ta5kvpXfThnFedVTtUy5yinrfS+/6gIxw7Hdm9BRRP2j/3frjQaAh4J Y7V4DjJX2A99XnWJMjCan11270sOZYDxbHErcRXonl4CMkQ+nqqUVH83wIFLuvGhVsqd spIT4MtHb7BSmUGAjumVsp8tvh0Kz5SCoPn9lADl5cLBV66JBCX5SJ4OH3Bblq+4p4qe 8xwrSZEb+zAo+n5wFubAmnwak9wM+yQc3ahOQ7qlAQvYy7D0VQplnC+wKQAjWDFKNeFS bMo3hprGvxKMnBtGGQV73mlIgiNftRjSXJnF6GjEpa7f5KXTfkopOElEEt94D427iMYc DFrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687265422; x=1689857422; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4h+QTnlc+AjTQChb9+JgWJSHU7FUP2xrURgAQ6QWhzg=; b=H3FnKC59ZLqW53Be00QRtBATO8Mf9uuoo216z87vKfDiW2lkT8nLX0Z/TKncBoDvmX PxNPLD0UWuQHn3qE4ONZG5xnmtRQIqilICvuz+9Ebd+jQkTdVD0nlX0TSX+TgqrqVADX qUuivvZkjdiTLKKvQ51QAGNyNjWLt0Lr1xHjtTWGGu2xZz7AQLDioFmqM84rVkTSibDI amyuA7daClL4Hv+qzuKzvBJcGQ0V/2Vm2szoZxeXRnhsy8P8o0k4Prfh6wg9Gs/+bvHW Mcbxhax3hqgMX9r/TLS6PBXkZZWeOk1q9u+D6rL8AaLLE5yrctTzqOo77YX9VneCT9j6 CNQw== X-Gm-Message-State: AC+VfDzgLYwBPxY2WqTMH+RTNhGTuZFuvcr2c1RNFBfmYkgC2nwsea+Y 843/qlD8mnOW+J9s1sEHm+vZbw== X-Google-Smtp-Source: ACHHUZ6KuPZ3AniannKBaVgcnQ+gNoecFU5Izf41c4JyKMb7O9xbIlPKBYIQ/iqjt9/Uffbp52U3DQ== X-Received: by 2002:a05:6808:4d3:b0:397:f82f:90a4 with SMTP id a19-20020a05680804d300b00397f82f90a4mr12262507oie.3.1687265421876; Tue, 20 Jun 2023 05:50:21 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:a14c:5cc9:ceb9:f9ce:f71c? ([2804:1b3:a7c2:a14c:5cc9:ceb9:f9ce:f71c]) by smtp.gmail.com with ESMTPSA id bf24-20020a056808191800b00395f2c84b81sm990394oib.54.2023.06.20.05.50.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 05:50:21 -0700 (PDT) Message-ID: Date: Tue, 20 Jun 2023 09:50:18 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 0/5] fcntl fortification Content-Language: en-US To: Maxim Kuvyrkov , Sergey Bugaev Cc: Carlos O'Donell , Libc-alpha , =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= References: <20230617222218.642125-1-bugaevc@gmail.com> <1249c048-c72d-0bf1-f0e0-2e619cfe5372@redhat.com> <783b1d24-f2b4-3a3c-d636-2b231be3b823@linaro.org> <2B723D88-546D-4AA6-8BDA-7B6CC9F5D404@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <2B723D88-546D-4AA6-8BDA-7B6CC9F5D404@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/06/23 02:59, Maxim Kuvyrkov wrote: >> On Jun 19, 2023, at 22:36, Adhemerval Zanella Netto wrote: >> >> >> >> On 19/06/23 11:23, Sergey Bugaev via Libc-alpha wrote: >>> On Mon, Jun 19, 2023 at 3:58 PM Carlos O'Donell wrote: >>>> Pre-commit CI regression caused by this series on both aarch64 and aarch32. >>>> https://patchwork.sourceware.org/project/glibc/patch/20230617222218.642125-6-bugaevc@gmail.com/ >>>> >>>> # Running glibc:io ... >>>> # FAIL: io/check-installed-headers-c >>>> # FAIL: io/check-installed-headers-cxx >>>> # >>>> # Running glibc:misc ... >>>> # FAIL: misc/check-installed-headers-c >>>> # FAIL: misc/check-installed-headers-cxx >>>> # >>>> # Running glibc:rt ... >>>> # FAIL: rt/check-installed-headers-c >>>> # FAIL: rt/check-installed-headers-cxx >>> >>> Thank you :( >>> >>> I'm a little bit lost in the Jenkins web UI -- is there anywhere I can >>> view the output of the failing tests to understand what exactly went >>> wrong? I see the sum files here [0], but not the .out files. >>> >>> [0]: https://ci.linaro.org/job/tcwg_glibc_check--master-arm-build/386/artifact/artifacts/artifacts.precommit/sumfiles/ > > Hi Sergey, > > See the attached tarball with output from failed tests: > === > Running glibc:io ... > FAIL: io/check-installed-headers-c > FAIL: io/check-installed-headers-cxx > > Running glibc:misc ... > FAIL: misc/check-installed-headers-c > FAIL: misc/check-installed-headers-cxx > > Running glibc:rt ... > FAIL: rt/check-installed-headers-c > FAIL: rt/check-installed-headers-cxx > === > > Let me know if you need any help in reproducing these. The results are for Ubuntu 22.04 armhf target, but results for Ubuntu 22.04 aarch64 show the same regressions. > > Interestingly the top-level check-installed-headers-* tests PASS: > === > PASS: check-installed-headers-c > PASS: check-installed-headers-cxx > === > >> >> I could not reproduce it locally, so I think it is a limitation of our >> (Linaro) CI framework, where not all tests artifacts are being removed >> with make test-clean. Maxim already sent a fix for this [1]. >> >> [1] https://patchwork.sourceware.org/project/glibc/patch/20230615152547.2924770-1-maxim.kuvyrkov@linaro.org/ > > Hi Adhemerval, > > We (Linaro) have fixed or added workarounds for all known testsuite stability problems in our CI before enabling reporting for failed patches. I am surprised that you could not reproduce the above failures in your setup; let's troubleshoot your local setup offline. I think I figure out what is happening here. I am using toolchains built with scripts/build-many-glibcs.py which does not set fortify as default, different than distro that are now setting the it as default. Since in our CI we use the system compiler to check for header, fortify will be always enabled and thus breaking the testing. Frédéric is fixing a lot of tests to assume fortify is enabled as default, so maybe it is something that he is already tracking. In any case, I think we should fix scripts/check-installed-headers.sh to check for different levels of _FORTIFY_SOURCE along with already in places flags.