From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35825 invoked by alias); 20 Feb 2018 13:38:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 35816 invoked by uid 89); 20 Feb 2018 13:38:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f194.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Fav1sHgMH4bh4AXybuaUKoD80Wfmtwz3W/5Ofar9hMg=; b=O9jbQ9VYu9PcstcMVfHpqTiTmVrCrBIS0YONOTcVnNU8pdZ93KRNwXdy+2L2O+m476 39IaEx8R01sISrMiFGtZO2t5GZ71an6lBxIerR0SnWctudC3PkTtGllyBc6xYpeZyZkY z6XbixIOAR/jm6MqRk7lxLbm7c6hU6Ut/3R2hU75+7HJcPCF4Kh9o8cBEB57SDzOIVkZ tNejBdpz97fnIUU8LIM2E+ibd01s4mqsiWKlr5+eeClPAJlvNMxctfYKfkriUwNs8t39 zwWpOJL78qsNhAEzyDKf1gvHkm49zZQN/xn0ZUEmpAkWIQzLY4RTDzLeLcYyw7i9oecz lcDQ== X-Gm-Message-State: APf1xPAyV9YdnG7p9SdaSBqL22Q8whmelXQ/DaCtc2R4i6V0TWBGO4Cs ILCTlAbYyXwGNEQQI0AmnBtC4rza3vQ= X-Google-Smtp-Source: AH8x226zXHhdAD4Z8fSQUBk5FM3Rc4PiM96Mt6OdTWPixhMYk+6Z+eZdIAHLTeVBrZaY001e53YiVQ== X-Received: by 10.237.37.161 with SMTP id x30mr29411997qtc.78.1519133909420; Tue, 20 Feb 2018 05:38:29 -0800 (PST) Subject: Re: [PATCH v4 1/4] Rename nptl-signals.h to internal-signals.h To: Florian Weimer , libc-alpha@sourceware.org References: <1518439345-6013-1-git-send-email-adhemerval.zanella@linaro.org> <954c3a04-12a5-fdd2-2a0e-c875f6e3d6d9@redhat.com> From: Adhemerval Zanella Message-ID: Date: Tue, 20 Feb 2018 13:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <954c3a04-12a5-fdd2-2a0e-c875f6e3d6d9@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-02/txt/msg00549.txt.bz2 On 20/02/2018 09:32, Florian Weimer wrote: > On 02/12/2018 01:42 PM, Adhemerval Zanella wrote: >> This patch renames the nptl-signals.h header to internal-signals.h. >> On Linux the definitions and functions are not only NPTL related, but >> used for other POSIX definitions as well (for instance SIGTIMER for >> posix times, SIGSETXID for id functions, and signal block/restore > > POSIX timers? > >> Signed-off-by: Adhemerval Zanella > > We don't use DCO, but have copyright assignments. Right, although I had the impression signed-off-by is mostly optional. I am trying to find the follow-up thread about it after it was brought up in Cauldron. Do you know if Carlos has written some wiki entry about it? > >> diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h >> diff --git a/sysdeps/unix/sysv/linux/nptl-signals.h b/sysdeps/unix/sysv/linux/internal-signals.h >> similarity index 89% >> rename from sysdeps/unix/sysv/linux/nptl-signals.h >> rename to sysdeps/unix/sysv/linux/internal-signals.h >> index e789198..e007372 100644 >> --- a/sysdeps/unix/sysv/linux/nptl-signals.h >> +++ b/sysdeps/unix/sysv/linux/internal-signals.h >> @@ -1,4 +1,4 @@ >> -/* Special use of signals in NPTL internals.  Linux version. >> +/* Special use of signals internally.  Linux version. >>      Copyright (C) 2014-2018 Free Software Foundation, Inc. >>      This file is part of the GNU C Library. >>   @@ -16,6 +16,9 @@ >>      License along with the GNU C Library; if not, see >>      .  */ >>   +#ifndef __INTERNAL_SIGNALS_H >> +# define __INTERNAL_SIGNALS_H >> + >>   #include >>   #include >>   @@ -35,17 +38,16 @@ >>     /* Return is sig is used internally.  */ >>   static inline int >> -__nptl_is_internal_signal (int sig) >> +__is_internal_signal (int sig) >>   { >> -  return (sig == SIGCANCEL) || (sig == SIGTIMER) || (sig == SIGSETXID); >> +  return (sig == SIGCANCEL) || (sig == SIGSETXID); > > Should this change be mentioned in the ChangeLog?  You could remove the unnecessary parens because you modify this line anyway. I will add a entry in ChangeLog and remove the unnecessary parentheses. > >>   /* Remove internal glibc signal from the mask.  */ >>   static inline void >> -__nptl_clear_internal_signals (sigset_t *set) >> +__clear_internal_signals (sigset_t *set) >>   { >>     __sigdelset (set, SIGCANCEL); >> -  __sigdelset (set, SIGTIMER); > > Likewise, should be mentioned in the ChangeLog entry. I will a entry as well. > > Looks okay otherwise. > > Thanks, > Florian