From: Stefan Liebler <stli@linux.vnet.ibm.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] s390x: Add hidden definition for __sigsetjmp
Date: Tue, 15 Nov 2016 13:19:00 -0000 [thread overview]
Message-ID: <f9a4d248-2fe6-bbc1-07fa-5ffc614e3ca9@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161114145753.3DF6D439942E0@oldenburg.str.redhat.com>
Hi Florian,
See the small comment below. Otherwise this patch is okay.
Thanks.
On 11/14/2016 03:57 PM, Florian Weimer wrote:
> 2016-11-14 Florian Weimer <fweimer@redhat.com>
>
> * sysdeps/s390/s390-64/setjmp.S (NEED_COMPAT_SYMBOLS): New macro.
> (libc_hidden_def): Remove redefinition.
> (__sigsetjmp): Add hidden definition.
> * sysdeps/s390/s390-32/setjmp.S (NEED_COMPAT_SYMBOLS): New macro.
> (libc_hidden_def): Remove redefinition.
> (__sigsetjmp): Add hidden definition.
>
> diff --git a/sysdeps/s390/s390-32/setjmp.S b/sysdeps/s390/s390-32/setjmp.S
> index dbacb0f..c460b5e 100644
> --- a/sysdeps/s390/s390-32/setjmp.S
> +++ b/sysdeps/s390/s390-32/setjmp.S
> @@ -24,17 +24,15 @@
> #include <shlib-compat.h>
> #include <stap-probe.h>
>
> -#if !IS_IN (rtld)
> -# if defined SHARED && SHLIB_COMPAT (libc, GLIBC_2_19, GLIBC_2_20)
> - /* we need a unique name in case of symbol versioning. */
> -# define setjmp __v1setjmp
> -# define _setjmp __v1_setjmp
> -# define __sigsetjmp __v1__sigsetjmp
> -
> -# undef libc_hidden_def
> -# define libc_hidden_def(name) strong_alias(_setjmp, __GI__setjmp)
> -# endif /* if defined SHARED && SHLIB_COMPAT (libc, GLIBC_2_19, GLIBC_2_20) */
> -#endif /* !IS_IN (rtld) */
> +#if !IS_IN (rtld) && defined SHARED && SHLIB_COMPAT (libc, GLIBC_2_19, GLIBC_2_20)
This line is too long and there are two spaces between && and SHLIB_COMPAT.
The same applies to sysdeps/s390/s390-64/setjmp.S.
next prev parent reply other threads:[~2016-11-15 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 14:57 Florian Weimer
2016-11-15 13:19 ` Stefan Liebler [this message]
2016-11-15 14:52 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9a4d248-2fe6-bbc1-07fa-5ffc614e3ca9@linux.vnet.ibm.com \
--to=stli@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).