From: Carlos O'Donell <carlos@redhat.com>
To: Andreas Schwab <schwab@suse.de>,
Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: amonakov@ispras.ru, GLIBC Devel <libc-alpha@sourceware.org>
Subject: Re: [patch] Fix path length overflow in realpath (BZ#22786)
Date: Wed, 11 Apr 2018 13:32:00 -0000 [thread overview]
Message-ID: <f9c6a562-b535-eaef-aacc-9528d662e332@redhat.com> (raw)
In-Reply-To: <87604z100r.fsf@linux-m68k.org>
On 04/10/2018 11:47 AM, Andreas Schwab wrote:
> On Apr 10 2018, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
>
>> It already took me significantly longer to write the test than to write the
>> fix :-(
>
> It's not unusual that writing meaningful tests is the hardest part.
100% Agreed.
If writing the test takes 100x longer than the fix it is *still* worth it.
Systems level programming is *all* about writing tests to exercise the system.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2018-04-11 13:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 23:02 Paul Pluzhnikov
2018-04-10 0:25 ` Paul Pluzhnikov
2018-04-10 8:08 ` Andreas Schwab
2018-04-10 14:54 ` Paul Pluzhnikov
2018-04-10 15:15 ` Andreas Schwab
2018-04-10 15:23 ` Paul Pluzhnikov
2018-04-10 15:31 ` Alexander Monakov
2018-04-10 15:44 ` Paul Pluzhnikov
2018-04-10 16:38 ` Alexander Monakov
2018-04-10 16:47 ` Andreas Schwab
2018-04-11 13:32 ` Carlos O'Donell [this message]
2018-04-17 21:01 ` Joseph Myers
2018-04-17 23:51 ` Paul Pluzhnikov
2018-04-30 21:42 ` Paul Pluzhnikov
2018-05-08 14:34 ` Paul Pluzhnikov
2018-05-08 14:59 ` Andreas Schwab
2018-05-08 15:11 ` Paul Pluzhnikov
2018-05-08 15:29 ` Andreas Schwab
2018-05-08 15:46 ` Paul Pluzhnikov
2018-05-09 11:11 ` Dmitry V. Levin
2018-05-09 14:23 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9c6a562-b535-eaef-aacc-9528d662e332@redhat.com \
--to=carlos@redhat.com \
--cc=amonakov@ispras.ru \
--cc=libc-alpha@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).