From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by sourceware.org (Postfix) with ESMTPS id 0BF643858402 for ; Mon, 17 Jan 2022 09:42:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0BF643858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 47E53281298; Mon, 17 Jan 2022 09:42:43 +0000 (UTC) Received: from pdx1-sub0-mail-a307.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9B9F8281141; Mon, 17 Jan 2022 09:42:42 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a307.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.158.96 (trex/6.4.3); Mon, 17 Jan 2022 09:42:43 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Drop-Wiry: 1bdc815d6ef1aa42_1642412563036_3989640184 X-MC-Loop-Signature: 1642412563036:3715870433 X-MC-Ingress-Time: 1642412563035 Received: from [192.168.1.174] (unknown [1.186.224.209]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a307.dreamhost.com (Postfix) with ESMTPSA id 4Jcn4x1SgTz3B; Mon, 17 Jan 2022 01:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1642412562; bh=gGTd+wd7GhHWeI7yeToD+Yhns04=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=T16PC7EdaZS7DUkwQ5KpRq35HrHzVhwMvpVcyheCwokghfGqJdg9OjqdqLdwvnI55 SrqRJOX1G5CaVye/OmLzwIqoQiwjwq6bxJ3qRKyCs1qelhYAv3Bl36Tfeu0G49ePeY d9+s6jbFPM/4Q7s6abn3kPGyag2N3yiLSEpfpow4= Message-ID: Date: Mon, 17 Jan 2022 15:12:35 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 3/4] sunrpc: Test case for clnt_create "unix" buffer overflow (bug 22542) Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <5e6f9d7240e55d438438d457f169132cf89fb8a0.1642148513.git.fweimer@redhat.com> <3c2a7cbc-9284-75dc-e7d0-8cab8571fe3a@gotplt.org> <87mtjuoh9a.fsf@oldenburg.str.redhat.com> <87fspmoggz.fsf@oldenburg.str.redhat.com> From: Siddhesh Poyarekar In-Reply-To: <87fspmoggz.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2022 09:42:47 -0000 On 17/01/2022 15:02, Florian Weimer wrote: > * Siddhesh Poyarekar: > >> On 17/01/2022 14:45, Florian Weimer wrote: >>> It has in linkobj/libc.so: >>> $ eu-readelf --symbols=.dynsym linkobj/libc.so | grep clnt_create >>> 3126: 000387a0 465 FUNC GLOBAL DEFAULT 14 clnt_create@@GLIBC_2.0 >> >> That's weird, shouldn't it be non-default given that it is deprecated? >> Why is it needed for internal linking? For tests? > > Yes. linkobj/libc.so and libc.so are different. It's a compatibility > symbol in libc.so. OK then. Reviewed-by: Siddhesh Poyarekar