From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 92B1B388702C for ; Wed, 8 Apr 2020 12:52:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 92B1B388702C Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-NuHkIw6ZMzGuwyAhDnGkdQ-1; Wed, 08 Apr 2020 08:52:51 -0400 X-MC-Unique: NuHkIw6ZMzGuwyAhDnGkdQ-1 Received: by mail-qt1-f198.google.com with SMTP id b3so6208015qte.13 for ; Wed, 08 Apr 2020 05:52:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=XSXKLLCOGh5aiPFb1cCYtc/7zKSdZty3efuL2qlCgZ4=; b=A6jcB6m1fPXa/qW9brIFfHnxdSdYId3mzaNa+83RXrn9vxOKalbIOP4fCH9m2TX7L2 V7a8lBYYEJKfk95jFs97lvAXz9B50j3CQs5oXMGCmW999l6pwboN0vItJgTSlrCksGhD hqeUh+9qpeWPR3agiBYX2y9nviIBLw0M+1bP8yF75FGxBKqcAmqZeuc7RF6UFENBIqEI eS6QGPkjyC6/chvuOCvcSc4GbjNeMLeICVQzgasBwXW32amn43Q3s/z4NHR+YfaaWJ3L h0assy+pUyIyKxEfMlKSSC2tY6G1t15bES3UZWWQiu55VJvmIDVjvFEJp4ltOC1vjTdS +FKw== X-Gm-Message-State: AGi0PuZpBzhVWC7a3U+RPXcdQohNF3jgJorJYHAqEvPdlJy09RmmPU7K aKEQnmNJx0zuZe8odIpDGSHSogxOaA8LXZZR4owRFRB12XI9uXzerf6xld6WWfgzOBNAPnrRnjC qN4zCWy9qLdbn9z3ERBUe X-Received: by 2002:ae9:ec0c:: with SMTP id h12mr7452599qkg.232.1586350370791; Wed, 08 Apr 2020 05:52:50 -0700 (PDT) X-Google-Smtp-Source: APiQypIMIIOR/etay8XVl/tBPZ4qngkkEdKbjOv6TU4i69kcUHeTOkz0WJAOHZAe5A7CpTr4cHMuMQ== X-Received: by 2002:ae9:ec0c:: with SMTP id h12mr7452585qkg.232.1586350370504; Wed, 08 Apr 2020 05:52:50 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id x17sm18639667qkb.87.2020.04.08.05.52.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2020 05:52:49 -0700 (PDT) Subject: Re: [PATCH v2 3/3] x86: Add the test case of __get_cpu_features support for Zhaoxin processors To: "May Shao(BJ-RD)" , "H.J. Lu" Cc: GNU C Library , "Cooper Yan(BJ-RD)" , "Herry Yang(BJ-RD)" , "Qiyuan Wang(BJ-RD)" , "Ricky Li(BJ-RD)" References: <1585546430-6167-1-git-send-email-MayShao@zhaoxin.com> <1585546430-6167-4-git-send-email-MayShao@zhaoxin.com> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Wed, 8 Apr 2020 08:52:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-21.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2020 12:52:56 -0000 On 4/7/20 10:36 PM, May Shao(BJ-RD) wrote: > > > On Tue, April 7, 2020 at 8:38 PM H.J. Lu wrote: >> >> On Sun, Mar 29, 2020 at 10:35 PM MayShao wrote: >>> >>> For the test case of the __get_cpu_features interface, add an item in >>> cpu_kinds and a switch case for Zhaoxin support. >>> >>> --- >>> sysdeps/x86/tst-get-cpu-features.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/sysdeps/x86/tst-get-cpu-features.c >> b/sysdeps/x86/tst-get-cpu-features.c >>> index 0f55987..0dcb906 100644 >>> --- a/sysdeps/x86/tst-get-cpu-features.c >>> +++ b/sysdeps/x86/tst-get-cpu-features.c >>> @@ -38,6 +38,7 @@ static const char * const cpu_kinds[] = >>> "Unknown", >>> "Intel", >>> "AMD", >>> + "ZHAOXIN", >>> "Other", >>> }; >>> >>> @@ -50,6 +51,7 @@ do_test (void) >>> { >>> case arch_kind_intel: >>> case arch_kind_amd: >>> + case arch_kind_zhaoxin: >>> case arch_kind_other: >>> printf ("Vendor: %s\n", cpu_kinds[cpu_features->basic.kind]); >>> printf ("Family: 0x%x\n", cpu_features->basic.family); >>> -- >>> 2.7.4 >> >> LGTM. >> >> BTW, have you finished your paperwork with FSF? > > Yes, I have finished the paperwork with FSF. If there is any problem, > please let me know. I confirm that we can accept patches only from May Shao from Zhaoxin. -- Cheers, Carlos.