From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>,
Joseph Myers <joseph@codesourcery.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] support: Introduce new subdirectory for test infrastructure
Date: Wed, 30 Nov 2016 14:16:00 -0000 [thread overview]
Message-ID: <fa3c0fbe-6019-fca7-c33b-f5989427b565@redhat.com> (raw)
In-Reply-To: <b54872a2-ed56-8f13-419c-651ee025b21f@redhat.com>
On 11/29/2016 01:41 AM, Florian Weimer wrote:
> On 11/29/2016 12:11 AM, Joseph Myers wrote:
>> In the new style, what is the recommended way of doing a
>> compile-only test (tests that presently do "#define TEST_FUNCTION
>> 0", like elf/tst-linkall-static.c)? Define a dummy test function
>> that just returns 0?
>
> Yes, that would be my preference for the time being. I hope that we
> will get real compile-time tests eventually. we really need them to
> check the fortify functionality and its warnings and errors.
That's certainly a use case that has failure modes we need to test.
I spent quite a while trying to get compile-time tests to work and there is a
lot of surgery required to make it work as expected and have the overrides
work correctly.
Even then the final solution I had was overly simplistic and didn't allow
layering of tests because the source to test mapping was quite simple.
FYI: https://sourceware.org/ml/libc-alpha/2016-06/msg00162.html
--
Cheers,
Carlos.
next prev parent reply other threads:[~2016-11-30 14:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 20:30 Florian Weimer
2016-11-28 21:51 ` Florian Weimer
2016-11-28 22:58 ` Andreas Schwab
2016-11-29 7:52 ` Florian Weimer
2016-12-02 19:21 ` Carlos O'Donell
2016-12-05 15:57 ` Florian Weimer
2016-12-07 13:20 ` Florian Weimer
2016-12-08 14:29 ` Carlos O'Donell
2016-12-10 15:08 ` Andreas Schwab
2016-12-10 19:17 ` Florian Weimer
2016-12-10 19:39 ` Andreas Schwab
2016-12-12 10:00 ` Florian Weimer
2016-12-12 18:16 ` Andreas Schwab
2016-12-10 15:23 ` [PATCH] Fix testsuite timeout handling Andreas Schwab
2016-12-10 15:36 ` Florian Weimer
2016-11-28 23:11 ` [PATCH] support: Introduce new subdirectory for test infrastructure Joseph Myers
2016-11-29 6:41 ` Florian Weimer
2016-11-30 14:16 ` Carlos O'Donell [this message]
2016-12-12 13:12 ` Stefan Liebler
2016-12-12 14:50 ` Florian Weimer
2016-12-12 16:38 ` Stefan Liebler
2016-12-12 22:16 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa3c0fbe-6019-fca7-c33b-f5989427b565@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).