From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caracal.birch.relay.mailchannels.net (caracal.birch.relay.mailchannels.net [23.83.209.30]) by sourceware.org (Postfix) with ESMTPS id E2A553858CDB for ; Wed, 4 Oct 2023 12:34:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2A553858CDB Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=sourceware.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C86A44C27E8; Wed, 4 Oct 2023 12:34:35 +0000 (UTC) Received: from pdx1-sub0-mail-a234.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 42AF54C2849; Wed, 4 Oct 2023 12:34:35 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696422875; a=rsa-sha256; cv=none; b=aYjsKBD991LlcRkQ/lL58mW/n9TkrX9z/BsWLXiKJmR+/UVFtUVmpqp1bG5IJsIIgpNleY +bpav+kcKs/xwnXMyfjVXeuAV2/WXVrF2ylaBwlzWTS2j405j5cviu3VmB8MT2KVGI+Zz2 tyVy1wCKVSL0avFsCBOI7+74jYQYqLnXuz3OxLoGnKaB8qEgIv3yIB8ztrSPX4IR5vw6Oh GINbajSg0/DkkgN7U9wcy7heYw+S5m5OJb6L/sI7UBKU10g3MfN66St290CB11fCTgwwSq NV57jDni0Ui4EvKnzefagc6oS66bXh2f4WNxOybIFuoZ177Yzw6DoU3jqXWj5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696422875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M5R7zsmsL1ehpI9fA5bo/WLCr05EalPKMXCxQXVnRXo=; b=9mlphbeIRAaL9nSpZTYymCdEaD/H9TPkCcOFuduIBd3bnOefiMZkDPnMcsfz6STGufvda7 hQkLmnk4nOWrbRIx3roWi411Bswa2fsvRFJAXBccuSB6l9bj/AIRpsvYzIFAGZ0TdKVTch KtDWtVToaBNX4J7L1BtaaUN7U6N3f3/+laM/rFXmb8j4SqGFU2odjwyiyAN+FvTZv/ZvbO jW5iaJXgTRSymij4oZwGWsZCUZh8XXRewr+evDvYaf4vz85JjHWT/m1ayRGjspbKWzNQ5z rwJ+kAqXtWhHHq4tCf0vPbALHKhY9JAmRZo9WAEjDGIL2V3ijGCeoJkO5cJW8w== ARC-Authentication-Results: i=1; rspamd-7c449d4847-g4fhq; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MC-Copy: stored-urls X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Lyrical-Left: 1aa80a3b7011cae8_1696422875579_3184306600 X-MC-Loop-Signature: 1696422875579:2459597260 X-MC-Ingress-Time: 1696422875579 Received: from pdx1-sub0-mail-a234.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.101.66.70 (trex/6.9.1); Wed, 04 Oct 2023 12:34:35 +0000 Received: from [192.168.2.12] (bras-vprn-toroon4834w-lp130-02-142-113-138-41.dsl.bell.ca [142.113.138.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a234.dreamhost.com (Postfix) with ESMTPSA id 4S0vJp4yzvzK9; Wed, 4 Oct 2023 05:34:34 -0700 (PDT) Message-ID: Date: Wed, 4 Oct 2023 08:34:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [committed 2/2] tunables: Terminate if end of input is reached (CVE-2023-4911) Content-Language: en-US To: Adhemerval Zanella Netto , libc-alpha@sourceware.org Cc: Carlos O'Donell , Arjun Shankar References: <20231003170811.64957-1-siddhesh@sourceware.org> <20231003170811.64957-3-siddhesh@sourceware.org> <51a2d2d6-883b-44e5-b857-33337d3260e0@linaro.org> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1167.1 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-04 08:20, Adhemerval Zanella Netto wrote: > I think it would be best to avoid changing AT_SECURE binaries semantic > through tunables or even environment setting (/etc/suid-debug). It > means adding back GLIBC_TUNABLES to unsecvars (so even non AT_SECURE > binaries won't see GLIBC_TUNABLES), do not process GLIBC_TUNABLES for > AT_SECURE (including malloc mcheck), and dropping any ill-formed > GLIBC_TUNABLES strings (so first parse and only apply well-formatted > ones). I started that process with this patchset[1] that's probably the most contentious (or maybe not) issue. If we get consensus on that, we can move to drop GLIBC_TUNABLES support completely for AT_SECURE in 2.39. > This would allow to just remove the tunables_strdup altogether, > simplifying the code a lot. It also means that any security tunable > (such as the glibc.mem.tagging) would also stop appling to AT_SECURE, > but I think we should stopping giving users to change secure binares > semantics even in this way. We won't get to drop tunables_strdup; it's still needed to make a copy to delimit tunable values. We can drop all the twiddling under the __libc_enable_secure though. > And I don't think we should make this changes iff we have a a trusted > system-wide tunable. Ack, I can live with that. Thanks, Sid [1] https://patchwork.sourceware.org/project/glibc/list/?series=25312