From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-73164-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 52391 invoked by alias); 8 Sep 2016 18:35:59 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 52364 invoked by uid 89); 8 Sep 2016 18:35:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*F:U*rth
X-HELO: mail-yb0-f195.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:sender:subject:to:references:cc:from:message-id
         :date:user-agent:mime-version:in-reply-to:content-transfer-encoding;
        bh=Jlx0RzNW7ZS9Zp9+FJfEeYZX+ztPCQ52oLM2T4TOUOs=;
        b=ZeA2juH14asHtWL7AKUezE+f6AnimOlMKkjAahEHa5IVuV5JCyFFTagF7vnHjfgHKM
         xSpNj0loPb2aZic2gSHY2EsHRmeGjxLgOP0Zd5WXjRGEJSAbWW3oTUBjTqTTXD7+9p0K
         Pl8vm32Kv8EkE/9tQn2CRYO26ORUQi4yk67DTYAJZJjS0lPcV1nh+s/3jDg1woyzQy30
         AqEwvUsHMRhG6vy6zR53/TmsVKFY88yNrG6f8qPe+UOwQHdiBFX2f5Ge0EqkkirKAPwL
         G+PDg8aGq8NjDB7OytL8L3vIcnQfbwpolgW+/1UxZJS3qjGDPzFpuXARh8aN0jcWkTEH
         J0pw==
X-Gm-Message-State: AE9vXwNrapCTtETnA1eRM9flc4n/ElfcRMJZuHuG5EOpIh49OtYQLfz8Zr1hbA1pkU7czw==
X-Received: by 10.37.198.207 with SMTP id k198mr1287740ybf.17.1473359755303;
        Thu, 08 Sep 2016 11:35:55 -0700 (PDT)
Subject: Re: [PATCH v3] getrandom system call wrapper [BZ #17252]
To: Florian Weimer <fweimer@redhat.com>, Andreas Schwab <schwab@suse.de>
References: <661db778-8110-82b2-2c41-d6195916cbea@redhat.com>
 <mvmlgz2eeb7.fsf@hawking.suse.de>
 <0e765666-3d0c-ef01-3ccc-82a11388c551@redhat.com>
 <77056253-5741-5213-f103-a88d01790bd3@twiddle.net>
 <721afeb6-4217-d7a5-bd66-3b1e3a4b0a49@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <fab0e37b-89a0-50a7-5116-1d99299a4aec@twiddle.net>
Date: Thu, 08 Sep 2016 18:35:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <721afeb6-4217-d7a5-bd66-3b1e3a4b0a49@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2016-09/txt/msg00140.txt.bz2

On 09/08/2016 11:32 AM, Florian Weimer wrote:
>> Using __asm__ to change the assembler name of the C-level symbol is probably
>> preferred for __GCC__.
> 
> This does not work in all cases because a getrandom function definition will
> inherit the asm alias on the prototype and interpose the supposedly-protected
> symbol.
> 
> But now that we have a <sys/random.h> header, maybe this isn't a problem—if an
> application includes the <sys/random.h> header, it shows that it is aware of
> getrandom, so it's less likely that it's interposing the function accidentally.

Indeed, that's what I was assuming.  I hadn't read the previous patches where
this header didn't exist.


r~