From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B11BB3857034 for ; Fri, 25 Sep 2020 03:18:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B11BB3857034 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-LhTJeL0gNWKBwnNMgznm1g-1; Thu, 24 Sep 2020 23:18:52 -0400 X-MC-Unique: LhTJeL0gNWKBwnNMgznm1g-1 Received: by mail-qk1-f199.google.com with SMTP id r184so1014734qka.21 for ; Thu, 24 Sep 2020 20:18:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=7rkOZ72afYv4WLYz7rsr3OmCA1zffr/iUoWgzL18wqo=; b=Ca4t82LTWZNaT99Qk6KZ9ZMbag2rhzCVU/AkR9e4o/G1zQfv5AWoiWwnSJhTYeT0kH 6y8IcIwtO2ik3qLMzaxOZcvKjE2iorQfmhlJXTYP0Lx2fRj1P9biRDOs3n1d8kBfzlW8 ikLBuZQ359JnH1vge57sqx9l8LSXk3JZcYGtDMSE6ccWOTD1QvOJsooxSR0TgczipcEr ICDnYIjA6G2XPGvMjIxSJsAuP7MIszKDPkc4Uep9r7qrY5blZsLwBawvpdJ6RVGJoHCl iTzOxzN/EpDGa13wahnYJwNWGOW2RxsKt2fCw2yqD9FCoC3kOYQ6AytqYkWJ7bVkx41n k2/w== X-Gm-Message-State: AOAM531sXBLBh7MgjC4yjK3ioex3owpgX9IJNmJ/+cd+qNegvWrQqfKz WLhTB3OUZSOqjvQZH2BhIfn2SjDxuIP2Q7IGmcub+zt6seg8gsGLU+n9Ej4UnqD1fs0CUxnZS6q hIxmDDDy754aP2uWQRKdJ X-Received: by 2002:a37:9bd8:: with SMTP id d207mr2410251qke.100.1601003931190; Thu, 24 Sep 2020 20:18:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+WHDH9oCQUenXPggUwOfX7pk92BGUbLsZjki/EVTFyGztR7vWbI+Mx9MjVKgtASZ3wgqQGg== X-Received: by 2002:a37:9bd8:: with SMTP id d207mr2410241qke.100.1601003930987; Thu, 24 Sep 2020 20:18:50 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id a52sm1140900qtc.22.2020.09.24.20.18.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2020 20:18:50 -0700 (PDT) Subject: Re: [PATCH] Set locale related environment variables in debugglibc.sh To: Arjun Shankar , Andreas Schwab Cc: libc-alpha@sourceware.org, "Gabriel F. T. Gomes" References: <20200923160655.GA16688@aloka.lostca.se> <87h7rnehow.fsf@igel.home> <20200924125555.GA35013@aloka.lostca.se> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Thu, 24 Sep 2020 23:18:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200924125555.GA35013@aloka.lostca.se> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2020 03:18:57 -0000 On 9/24/20 8:55 AM, Arjun Shankar wrote: > On Thu, Sep 24, 2020 at 09:51:11AM +0200, Andreas Schwab wrote: > >>> +# Container tests needing locale data should install them in-container. >>> +# Other tests/binaries need to use locale data from the build tree. >>> +if [ "$$CONTAINER" == false ] >> >> `==' is non-POSIX. > > Thanks, Andreas. I'll replace with `='. The whole of debugglibc.sh is a bash script and as such may use bash constructs, and indeed has other instances of '=='. However, there is value in simplifying this to make it POSIX shell compatible. -- Cheers, Carlos.