From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/2] linux: Consolidate sigaction implementation
Date: Tue, 11 Dec 2018 17:49:00 -0000 [thread overview]
Message-ID: <fb0bc949-284b-d6ae-ca93-5b3fbe36e756@linaro.org> (raw)
In-Reply-To: <mvmzhtd9wip.fsf@suse.de>
On 10/12/2018 14:28, Andreas Schwab wrote:
> On Nov 17 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>
>> - All architectures now define and use a kernel_sigaction struct meant
>> for the syscall, even for the architectures where the user sigaction
>> has the same layout of the kernel expected one (s390-64 and ia64).
>> Although it requires more work for these architectures, it simplifies
>> the generic implementation. Also, sigaction is hardly a hotspot where
>> micro optimization would play an important role.
>>
>> - The generic kernel_sigaction definition is now aligned with expected
>> UAPI one for newer ports, where SA_RESTORER and sa_restorer is not
>> expected to be defined. This means adding kernel_sigaction for
>> current architectures that does define it (m68k, nios2, powerpc, s390,
>> sh, sparc, and tile) and which rely on previous generic definition.
>
> There is no need to define kernel_sigaction in more than one file, since
> it is the same (except for the presense of sa_restorer) for all
> architectures.
Indeed currently we have some architectures with duplicated definition
(alpha, s390, ia64, and hppa), however mips still requires its own
definition (__ARCH_HAS_IRIX_SIGACTION).
I am working on a fix for BZ#23960 along with a cleanup for
kernel_sigaction.
prev parent reply other threads:[~2018-12-11 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 20:35 Adhemerval Zanella
2017-11-17 20:34 ` [PATCH 2/2] i386: Fix i386 sigaction sa_restorer initialization (BZ#21269) Adhemerval Zanella
2018-12-10 17:01 ` [PATCH 1/2] linux: Consolidate sigaction implementation Andreas Schwab
2018-12-11 17:49 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb0bc949-284b-d6ae-ca93-5b3fbe36e756@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).