From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 601143858D32 for ; Thu, 25 May 2023 14:30:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 601143858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-39415d3526bso613191b6e.2 for ; Thu, 25 May 2023 07:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685025058; x=1687617058; h=content-transfer-encoding:in-reply-to:organization:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2EOOGpn/aVIKNTLErS2sO5tt5/WtyE25aAogNHooGyE=; b=mWjp6LdQJ4uQVKm1mqoShP5p25gx7A2dTevXjXOU8KY++Rqmjt7/1cVYfwF/0Jnqg7 yh4lUz1cINStvzO5skxIUnZHJWDsMJVwLGOJOdujF4YK1UwedvwTbwV6c0ukuOrpeGqj UWKl1YuI9GnS1NNU8ypANFEhSRhOmZPa7SvaTrWf/34Ajf3h95K5MZLtifXKTKE8PAhN UHxwXLjbVShUfC+fxZxN1hP3cFiVTzQT64fanFCKsrpyMk0wu6RzAdYTQTBlx1xHdN9G bZqQk8boscY+tRcJZEb2Mr31Fe8B5+0DKIVmEMuAez6lQgvmO3BpSihcUorGWuKrfpPF 3miA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685025058; x=1687617058; h=content-transfer-encoding:in-reply-to:organization:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2EOOGpn/aVIKNTLErS2sO5tt5/WtyE25aAogNHooGyE=; b=OTC/qiAWWA4edQkd7CgeIUsTJy5c5b1B2QVRPzhQvg5+y5BA/L15lHNerk5EAjbNiT DY8Dn1AKbbwBEROKfL1TxAGkcQQNn6phAZ2NxkHI5a1pSILyCLY8z1whB51rxehXmYaC pg71D4y4Ma9HBdIPAgmktHqQShSHaoDDj9X+K0SdXtW54aOP86K1+F+YOCawNo8lDYOK cL4BgattZ9w52MOgBa0XRoYtfxptJAo15SBLvSTcIxsrW14TkoA+AuZH9QMxQu+NYAD3 LPixDEEVtIB/NhWZF0aPuBdjJGmPklFnidBi8SAe6NgDXYlVlYxpM6c6f3ND5TMxH+Bc zG9g== X-Gm-Message-State: AC+VfDw5RWYaC1RY4k5e0bGnilm1NG0Aulp43uHTo74GoOB4YgOhuQoj VQcUzuyo8m2/KFxeiE2eoAk7UjLbhtcEWvzYNX6B4A== X-Google-Smtp-Source: ACHHUZ57L0vgMd+N4gb/wL9cHMT6J9ONeG1ukVUoVtA5vDrhg4OVZA5cF/Us/ANuwmHTgMQn2rtOkQ== X-Received: by 2002:a05:6808:60d:b0:398:59be:99a2 with SMTP id y13-20020a056808060d00b0039859be99a2mr1773983oih.32.1685025058336; Thu, 25 May 2023 07:30:58 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:4dd5:80c6:51f7:4cf7:20d3? ([2804:1b3:a7c1:4dd5:80c6:51f7:4cf7:20d3]) by smtp.gmail.com with ESMTPSA id u5-20020a544385000000b0039466dd53fasm546639oiv.19.2023.05.25.07.30.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 07:30:57 -0700 (PDT) Message-ID: Date: Thu, 25 May 2023 11:30:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH v2] wchar: Define va_list for POSIX (BZ #30035) From: Adhemerval Zanella Netto To: libc-alpha@sourceware.org, Andreas Schwab References: <20230124174959.1718640-1-adhemerval.zanella@linaro.org> <61890062-04b1-d709-abf3-ede0ba32bd0e@linaro.org> <18ef4af7-d89d-01a7-628b-7287679eec06@linaro.org> Content-Language: en-US Organization: Linaro In-Reply-To: <18ef4af7-d89d-01a7-628b-7287679eec06@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping (x3). On 22/03/23 10:11, Adhemerval Zanella Netto wrote: > Ping (x2). > > On 09/02/23 16:43, Adhemerval Zanella Netto wrote: >> Ping. >> >> On 24/01/23 14:49, Adhemerval Zanella wrote: >>> This was uncovered by a recent clang change [1]. Different than ISO C, >>> POSIX states that va_list should be exported by wchar.h [2]. >>> >>> Checked on x86_64-linux-gnu and aarch64-linux-gnu. >>> >>> [1] https://reviews.llvm.org/D137268 >>> [2] https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/basedefs/wchar.h.html >>> --- >>> conform/data/wchar.h-data | 3 +++ >>> wcsmbs/wchar.h | 11 +++++++++++ >>> 2 files changed, 14 insertions(+) >>> >>> diff --git a/conform/data/wchar.h-data b/conform/data/wchar.h-data >>> index e414651a33..0af74e14bc 100644 >>> --- a/conform/data/wchar.h-data >>> +++ b/conform/data/wchar.h-data >>> @@ -15,6 +15,9 @@ type size_t >>> type locale_t >>> # endif >>> tag {struct tm} >>> +# if !defined ISO99 && !defined ISO11 && !defined UNIX98 >>> +type va_list >>> +# endif >>> >>> function wint_t btowc (int) >>> function int fwprintf (FILE*, const wchar_t*, ...) >>> diff --git a/wcsmbs/wchar.h b/wcsmbs/wchar.h >>> index 69e920b8c2..ca145bb8d2 100644 >>> --- a/wcsmbs/wchar.h >>> +++ b/wcsmbs/wchar.h >>> @@ -37,6 +37,17 @@ >>> #define __need___va_list >>> #include >>> >>> +#if defined __USE_XOPEN2K || defined __USE_XOPEN2K8 >>> +# ifdef __GNUC__ >>> +# ifndef _VA_LIST_DEFINED >>> +typedef __gnuc_va_list va_list; >>> +# define _VA_LIST_DEFINED >>> +# endif >>> +# else >>> +# include >>> +# endif >>> +#endif >>> + >>> #include >>> #include >>> #include