From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id 8AA833851C39 for ; Wed, 24 Mar 2021 15:46:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8AA833851C39 Received: by mail-qk1-x72d.google.com with SMTP id x14so18456158qki.10 for ; Wed, 24 Mar 2021 08:46:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MgJbWIBsqTwxH/bLoLyPTnbZq73eq/39LCR+nevJPdU=; b=AvUKK6eyb3M1YsJ2iAfFWbT+5PWlSA3JpJr1VLvul2eDapCiTjELs/2V8l5JMVi6xZ PMiurEhitac1uMIS8MlOaBow18Ci0xcKp8ZUD2QHY2acGdGMMEUeerbgvEq6yLB0T6e5 SLBBJFQGbHb1Ep6JDMV3yET7avceFTYz1M+w9l0m7LQApHreO1ZYG6L2ZEka9EGTvUB/ GEX2ieToWv7td/UGJdpVDW7TyywxmzX9ZnS9NNehEtZn7v/F0RdBv/dfdiGdl2+0ksDx kH1JNfkbZ9dmDi5TsuauTU8Wj5w4DH2FsDHAl/okpYzj0n/H8oqxAW4USpJlgVukJlyz 5Fow== X-Gm-Message-State: AOAM531s8rPz+F/MZZQiPF28zzesKErsr/OLx5uuyUi1Sx4hemWmlAT+ DABWK+n7QRqID03r4Fr98X97oCEiw4huDA== X-Google-Smtp-Source: ABdhPJym3Wy2AQcoQYAYQ0l5euE008CbOtPQc3BzykYBUXeZxqGQtcvkjJZM0UGXkW0m/55YfkX6ag== X-Received: by 2002:a37:63d1:: with SMTP id x200mr3710353qkb.179.1616600782990; Wed, 24 Mar 2021 08:46:22 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id i25sm1918875qka.38.2021.03.24.08.46.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 08:46:22 -0700 (PDT) Subject: Re: [PATCH v3 24/37] nptl: Move pthread_key_create, __pthread_key_create into libc To: Florian Weimer Cc: libc-alpha@sourceware.org References: <5118e919-fac6-a116-5f39-3915fdc0e0af@linaro.org> <87h7l0wrjj.fsf@oldenburg.str.redhat.com> <0794e296-158f-26a4-f49b-b8e8aef5b305@linaro.org> <878s6cwpw6.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Wed, 24 Mar 2021 12:46:20 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <878s6cwpw6.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 15:46:24 -0000 On 24/03/2021 12:08, Florian Weimer wrote: > * Adhemerval Zanella: > >> Sigh... the description at libgcc/gthr-posix.h is *really* hacky and I >> think we provide the __libc_single_threaded exactly to avoid keep >> providing this kind of interfaces. > > The newer versions should use it, but there is just one header file > shared by everything POSIX-like. > >>> Right that, applies in other places throughout the series, too. >>> >>> Speaking of which, should I repost the compat_symbol patches? >> >> Isn't the one in patchwork the latest [1]? >> >> [1] https://patchwork.sourceware.org/project/glibc/patch/07c2defd7f03c5f2493a4132de673f33457d7806.1616184336.git.fweimer@redhat.com/ > > I think it lacks the __attribute__ ((nocommon)) for > __malloc_initialize_hook (need for building with GCC 9 and earlier). Ah right, I think there is no need for a newer version. I review/ack the one you already sent.