From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id A83E1385141E for ; Tue, 30 Aug 2022 06:23:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A83E1385141E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.187] (unknown [10.20.4.187]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxT+DJrA1jWD8MAA--.54365S3; Tue, 30 Aug 2022 14:23:06 +0800 (CST) Subject: Re: [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13 To: Xi Ruoyao , Adhemerval Zanella Netto , libc-alpha@sourceware.org Cc: Joseph Myers , Wang Xuerui References: <9146983bcb2dc77fea7ab361f96005b1ce6dc698.camel@xry111.site> <532ed62c-8510-c351-9cf2-342771a09a94@linaro.org> <7eba37096433a9030a4587fe80ad683f79432a32.camel@xry111.site> From: caiyinyu Message-ID: Date: Tue, 30 Aug 2022 14:23:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <7eba37096433a9030a4587fe80ad683f79432a32.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8CxT+DJrA1jWD8MAA--.54365S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY27k0a2IF6w1UM7kC6x804xWl14x267AK xVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGw A2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26r4j 6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Gr 1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Cr1j6rxdM2AIxVAIcxkEcVAq07x20xvE ncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I 8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY 0VAS07AlzVAYIcxG8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7 v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF 1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIx AIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI 42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxh VjvjDU0xZFpf9x07jY6wZUUUUU= X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_NUMSUBJECT,KAM_SHORT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I have tested it and pushed. 在 2022/8/30 下午1:31, Xi Ruoyao 写道: > On Mon, 2022-08-29 at 09:44 -0300, Adhemerval Zanella Netto wrote: >> >> On 20/08/22 05:43, Xi Ruoyao wrote: >>> GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use >>> them instead of the generic implementation. >>> >>> Link: https://gcc.gnu.org/r13-2085 >>> Signed-off-by: Xi Ruoyao >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella  > Thanks, I don't have a write access to glibc.git and need others' help > to push the patch :). > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id A83E1385141E for ; Tue, 30 Aug 2022 06:23:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A83E1385141E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.187] (unknown [10.20.4.187]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxT+DJrA1jWD8MAA--.54365S3; Tue, 30 Aug 2022 14:23:06 +0800 (CST) Subject: Re: [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} with GCC >= 13 To: Xi Ruoyao , Adhemerval Zanella Netto , libc-alpha@sourceware.org Cc: Joseph Myers , Wang Xuerui References: <9146983bcb2dc77fea7ab361f96005b1ce6dc698.camel@xry111.site> <532ed62c-8510-c351-9cf2-342771a09a94@linaro.org> <7eba37096433a9030a4587fe80ad683f79432a32.camel@xry111.site> From: caiyinyu Message-ID: Date: Tue, 30 Aug 2022 14:23:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <7eba37096433a9030a4587fe80ad683f79432a32.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf8CxT+DJrA1jWD8MAA--.54365S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY27k0a2IF6w1UM7kC6x804xWl14x267AK xVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGw A2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26r4j 6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Gr 1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Cr1j6rxdM2AIxVAIcxkEcVAq07x20xvE ncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I 8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY 0VAS07AlzVAYIcxG8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7 v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF 1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIx AIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI 42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxh VjvjDU0xZFpf9x07jY6wZUUUUU= X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, KAM_SHORT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2022 06:23:28 -0000 Message-ID: <20220830062305.LGI-zh1TcWkjMZSZ-m3F3J5reRXRwm1vwoz4C9LwIMc@z> I have tested it and pushed. 在 2022/8/30 下午1:31, Xi Ruoyao 写道: > On Mon, 2022-08-29 at 09:44 -0300, Adhemerval Zanella Netto wrote: >> >> On 20/08/22 05:43, Xi Ruoyao wrote: >>> GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use >>> them instead of the generic implementation. >>> >>> Link: https://gcc.gnu.org/r13-2085 >>> Signed-off-by: Xi Ruoyao >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella  > Thanks, I don't have a write access to glibc.git and need others' help > to push the patch :). >