From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 131253858281 for ; Fri, 3 Mar 2023 13:03:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 131253858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-17683b570b8so47421fac.13 for ; Fri, 03 Mar 2023 05:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677848621; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=SOY+z7N17hang3vqXVwRtIh4fX5LmHY0u6JXNR73ks8=; b=LFSBAy96iCpl2dka+HQPYPvq7g91FEQ6bSMi9182Sj6cY4FVEmpMquM98+l7Xeai7h 2XkMveN88ZcyDKYm6PT32E+2I2XRN1VpFyTzgy79itU8pTJnrbv5vEO2qH34Ni6ppTiT a77FvJUWDowIMS+d/GIXtIkrurt4RYUEzXIwXBPN0oUI90udNVR53jmQxD4hkUD2sEte O5eC8/RwW9yzfM2HrG+VkVO24/nklSD5+hbLsd5j+BzD8T8aD1XCO9izBrKX6xh8uNVC mlZzltR8oTOLiHfytlCuxA74xGLXFyanE35HpIeGJJiJBtkJTCT1Ou0uYs5pbAklUa5J 3N6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677848621; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SOY+z7N17hang3vqXVwRtIh4fX5LmHY0u6JXNR73ks8=; b=EpDC9BGyD/3uoMvPltCZAMO/Bch4YgjPE+ijjJgNXH6z6vRb/Fj5+dykt5eGwuY2UT KzcRho/014CmAp+GGWBmZ1q3waelLGMO5Bqzjf5+5eYhktPoQUQDDiifKJM+8X2yVLB5 D+sbaEADLOFfaNa40AKHf9tIUKKoem7qPnIeK3cD5ug5pLsAslIqFV7nrDoEwa3rNKj9 fyn6xOx7HmEG1MsHVwarCLiRV0q4h+mVpvvbSJ7uzpVgz1M3bwMgnyEEj5uCR7agyr6S VJu5C5ggkGyfnt6cXGYrDzFqh25euEfFN75b0o99fquPVdpu6PPk9YQOpiC9dK8yW4LL JaVQ== X-Gm-Message-State: AO0yUKWLW2/aNFU64y2Q3tNikTFyXncvP3shlZRK2Bdcx8oWwBM5B/6+ NLjKiI4orad3p7mSIkIuhQwLRg== X-Google-Smtp-Source: AK7set9nd6Ac4PUxSXtp5t+YL4KScELdnq/UoOcyEbsJMb01EZoxWhktS5y/Xr09MGjymHehJc+/dg== X-Received: by 2002:a05:6871:414:b0:176:3aed:f305 with SMTP id d20-20020a056871041400b001763aedf305mr1015900oag.49.1677848621277; Fri, 03 Mar 2023 05:03:41 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c3:d849:65ac:94e7:b706:d532? ([2804:1b3:a7c3:d849:65ac:94e7:b706:d532]) by smtp.gmail.com with ESMTPSA id x12-20020a4a620c000000b00525273db47fsm722193ooc.46.2023.03.03.05.03.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 05:03:40 -0800 (PST) Message-ID: Date: Fri, 3 Mar 2023 10:03:38 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] linux: fix ntp_gettime abi break Content-Language: en-US To: =?UTF-8?Q?Kacper_Piwi=c5=84ski?= , Carlos O'Donell Cc: libc-alpha@sourceware.org References: From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/03/23 05:47, Kacper Piwiński via Libc-alpha wrote: > czw., 2 mar 2023 o 18:47 Carlos O'Donell napisał(a): >> >> On 2/20/23 23:04, Kacper Piwiński via Libc-alpha wrote: >>> Between versions v2.11 and v2.12 struct ntptimeval got new fields. >>> That wasn't a problem because new function ntp_gettimex was created >>> (and made default) to support new struct. Old ntp_gettime was not >>> using new fields so it was safe to call with old struct >>> definition. Then between versions v2.31 and v2.32 when working on >>> y2038 bugs, ntp_gettime start setting new fields. >>> >>> Sets fields manually to maintain compatibility with v2.11 struct definition. >> >> The patch fails to apply. >> >> This fails pre-commit CI: >> https://patchwork.sourceware.org/project/glibc/patch/CAKVti-BRav=mmfcQBEz_qpezmKfR_fFW9uihJb+QXiJazugTmA@mail.gmail.com/ >> >> Please have a look at: >> https://sourceware.org/glibc/wiki/Contribution%20checklist >> >> Did you generate the patch with `git format-patch`? >> > > Hi, yes I did but I didn't copy the whole thing. Anyway this patch is > not correct. I attatched new patch here > https://sourceware.org/bugzilla/show_bug.cgi?id=30156 Could you please resend as v2? Patch submission and discussion are done through the maillist. PS: maybe we should be more clear on wiki that patches are done discussed on bugzilla.