From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id 824BC3856DCA for ; Wed, 13 Jul 2022 19:56:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 824BC3856DCA Received: by mail-oi1-x233.google.com with SMTP id n206so6782873oia.6 for ; Wed, 13 Jul 2022 12:56:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:cc:in-reply-to :content-transfer-encoding; bh=XCNJSim67JjwcU31LEUjfEVK6ulhAVYQann7kusj02Y=; b=KVtegy+zAgw8kqKX29iCl13XNv3AfByprPZD+GXR97W7k6U6iYJC9oXbQsXYozTT0d 51SVQWy8dmeEJYC5nmA4IK4rq2OyP2ZVH2tSFCPNFJjkTCJ+XWezBUrES+XufZOHZXIB UphUQelJsp3DbyvuXNO5vNZnCIY1emRcUWZM7/CNMnN7Gs5JD0TiUJSzrLVoXad4oyIw LYkGEPuulyNG+0xYouyMel/RNrH3+QQ1VwYTwjyZ0HaA0jeVVezsQPKdfKI2MGi1hV/C jbnMvyZbNQ3hG8HQyLpbqQZdVC/S5nHt/QKjd5GZ3zZ4WwYfbddLxb8cQs9EyVmhFHWH +sUQ== X-Gm-Message-State: AJIora+2YHxua8AHmXNip4qKAZ8GUVe6ox4pH5u1aO6EPEukqo6uqFfZ abBNCs8kl6V1j+xJF/b4sW9xRoVxv89Xcg== X-Google-Smtp-Source: AGRyM1vH1PIPkvgY6sJMPFhfNoICz17vFO3ixM7yt8x3A92MpW0gUYmIbCNvHJBRX0xqW/5ReOgkGw== X-Received: by 2002:a05:6808:1a0d:b0:33a:176c:2cbc with SMTP id bk13-20020a0568081a0d00b0033a176c2cbcmr2712212oib.155.1657742159603; Wed, 13 Jul 2022 12:55:59 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:19c3:4427:c171:4fa9:c3d9? ([2804:431:c7ca:19c3:4427:c171:4fa9:c3d9]) by smtp.gmail.com with ESMTPSA id q16-20020a056830441000b00616d3ec6734sm4487969otv.53.2022.07.13.12.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 12:55:59 -0700 (PDT) Message-ID: Date: Wed, 13 Jul 2022 16:55:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v6 00/13] GLIBC LoongArch PATCHES Content-Language: en-US To: libc-alpha@sourceware.org, caiyinyu , Xi Ruoyao , Carlos O'Donell References: <20220708065255.2316410-1-caiyinyu@loongson.cn> <7cbacfadd642bafc42076eb5b7455a0acb7c720f.camel@xry111.site> From: Adhemerval Zanella Netto Organization: Linaro Cc: joseph_myers@mentor.com In-Reply-To: <7cbacfadd642bafc42076eb5b7455a0acb7c720f.camel@xry111.site> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 19:56:02 -0000 On 08/07/22 04:13, Xi Ruoyao via Libc-alpha wrote: > On Fri, 2022-07-08 at 14:52 +0800, caiyinyu wrote: > >> binutils:       https://github.com/loongson/binutils-gdb/tree/dev/new_reloc > > There are too much changes in this branch. Could you isolate a minimal > binutils patch enough for eliminating R_LARCH_NONE and R_LARCH_IRELATIVE > from .rela.plt, get it reviewed, and push it into GNU binutils repo? I > don't think it's a good idea to make *GNU* libc depend on some external > linker code which is not reviewed by GNU binutils developers. > > And we need to do this ASAP: we already missed binutils 2.39 release > branch cut date [1] and if we don't move fast we'll miss glibc-2.36 > release date. > > [1]: https://sourceware.org/pipermail/binutils/2022-July/121567.html > > I finished my review for the port and it looks ok in general, however there some pieces that would require a v7: 1. Add R_LARCH_NONE handling on bootstrap, binutils 2.38 does generated it and from previous discussion it should be considered a missed optimizations instead of a linker error. 2. Remove the __loongarch_soft_float parts, since there is no support for soft floating-point. 3. Remove sysdeps/unix/sysv/linux/loongarch/ldconfig.h, this file is not required. 4. Some minor style issues. 5. Either remove HAVE_GETTIMEOFDAY_VSYSCALL or add a gettimeofday ifunc optimization. The only part really prevent port inclusion is 1. I am also assuming ifunc is support (at least you have added support on the Linux ABI part) with binutils 2.38. If not, you will need to remove support until you fix it on binutils. And also, you need to check and report the test results using the expected defined release branches, using out-of-tree branches are not acceptable for inclusion.