public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org, fweimer@redhat.com, carlos@redhat.com
Subject: Re: [PATCH v2] getaddrinfo: Fix use after free in getcanonname (CVE-2023-4806)
Date: Thu, 14 Sep 2023 06:06:11 -0400	[thread overview]
Message-ID: <fcd21313-b541-dc42-e889-e22bcb9db09d@sourceware.org> (raw)
In-Reply-To: <mvmedj1vzv0.fsf@suse.de>

On 2023-09-14 06:00, Andreas Schwab wrote:
> On Sep 14 2023, Siddhesh Poyarekar wrote:
> 
>> On 2023-09-14 05:55, Andreas Schwab wrote:
>>> On Sep 14 2023, Siddhesh Poyarekar wrote:
>>>
>>>> On 2023-09-14 04:37, Andreas Schwab wrote:
>>>>>> +static void do_prepare (int a, char **av)
>>>>>> +{
>>>>>> +  FILE *hosts = xfopen ("/etc/hosts", "w");
>>>>> Doesn't that mean the test needs to be run as root?
>>>>>
>>>>
>>>> Yes, that's why it's a container test.
>>> I don't see where it's enabled.
>>>
>>
>> Right here in nss/Makefile:
> 
> No, there is no root.
> 

AFAICT, all container tests run as root within the container.  I can add 
su in the script file to make it explicit, but it's working without it 
at the moment.  Would you prefer that?

Thanks,
Sid

  reply	other threads:[~2023-09-14 10:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 17:36 [PATCH] " Siddhesh Poyarekar
2023-09-13 19:03 ` Florian Weimer
2023-09-13 20:56 ` [PATCH v2] " Siddhesh Poyarekar
2023-09-14  8:37   ` Andreas Schwab
2023-09-14  9:48     ` Siddhesh Poyarekar
2023-09-14  9:55       ` Andreas Schwab
2023-09-14  9:57         ` Siddhesh Poyarekar
2023-09-14 10:00           ` Andreas Schwab
2023-09-14 10:06             ` Siddhesh Poyarekar [this message]
2023-09-14 10:12               ` Andreas Schwab
2023-09-14 10:24                 ` Siddhesh Poyarekar
2023-09-14 10:13 ` [PATCH v3] " Siddhesh Poyarekar
2023-09-14 10:53   ` Florian Weimer
2023-09-14 11:27     ` Siddhesh Poyarekar
2023-09-14 22:52   ` Carlos O'Donell
2023-09-15 18:41 ` [COMMITTED] " Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcd21313-b541-dc42-e889-e22bcb9db09d@sourceware.org \
    --to=siddhesh@sourceware.org \
    --cc=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).