public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: MAHESH BODAPATI <bmahi496@linux.ibm.com>, libc-alpha@sourceware.org
Cc: Mahesh Bodapati <mahesh.bodapati@ibm.com>
Subject: Re: [PATCH] Naming the parameter of dummy_sa_handler
Date: Mon, 13 Feb 2023 13:22:10 -0300	[thread overview]
Message-ID: <fcff19f5-4e0d-095e-c4db-fb92a848225f@linaro.org> (raw)
In-Reply-To: <20230213150703.2638293-1-bmahi496@linux.ibm.com>



On 13/02/23 12:07, MAHESH BODAPATI via Libc-alpha wrote:
> From: Mahesh Bodapati <mahesh.bodapati@ibm.com>
> 
> ISO C does not support omitting parameter names in function definitions
> before C2X,the compiler is giving an error with older versions of gcc and
> this commit will resolve the test failure "error: parameter name omitted"

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  posix/tst-spawn7.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/posix/tst-spawn7.c b/posix/tst-spawn7.c
> index a1c0d9d942..fedb09fb94 100644
> --- a/posix/tst-spawn7.c
> +++ b/posix/tst-spawn7.c
> @@ -92,7 +92,7 @@ spawn_signal_test (const char *type, const posix_spawnattr_t *attr)
>  }
>  
>  static void
> -dummy_sa_handler (int)
> +dummy_sa_handler (int signal)
>  {
>  }
>  

      reply	other threads:[~2023-02-13 16:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 15:07 MAHESH BODAPATI
2023-02-13 16:22 ` Adhemerval Zanella Netto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcff19f5-4e0d-095e-c4db-fb92a848225f@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=bmahi496@linux.ibm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=mahesh.bodapati@ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).