From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Arjun Shankar <arjun@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 01/16] inet: Rearrange and sort Makefile variables
Date: Mon, 2 Oct 2023 10:11:23 -0400 [thread overview]
Message-ID: <fd577aaa-1971-7aa1-f7e6-6a4ac6d46b21@gotplt.org> (raw)
In-Reply-To: <20231002130150.1497733-2-arjun@redhat.com>
On 2023-10-02 08:55, Arjun Shankar wrote:
> Rearrange lists of routines, tests, etc. into one-per-line in
> inet/Makefile and sort them using scripts/sort-makefile-lines.py.
> ---
This is a trivial, independent cleanup, please push.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
> inet/Makefile | 142 +++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 112 insertions(+), 30 deletions(-)
>
> diff --git a/inet/Makefile b/inet/Makefile
> index f5249ab2b1..9db7f941c6 100644
> --- a/inet/Makefile
> +++ b/inet/Makefile
> @@ -22,41 +22,123 @@ subdir := inet
>
> include ../Makeconfig
>
> -headers := netinet/ether.h netinet/in.h netinet/in_systm.h \
> - netinet/if_ether.h netinet/igmp.h \
> - netinet/tcp.h netinet/ip.h $(wildcard arpa/*.h protocols/*.h) \
> - aliases.h ifaddrs.h netinet/ip6.h netinet/icmp6.h bits/in.h \
> - rpc/netdb.h
> -
> -routines := htonl htons \
> - inet_lnaof inet_mkadr \
> - inet_netof inet_ntoa inet_net herrno herrno-loc \
> - gethstbyad gethstbyad_r gethstbynm gethstbynm2 gethstbynm2_r \
> - gethstbynm_r gethstent gethstent_r \
> - getnetbyad getnetbyad_r getnetbynm getnetent getnetent_r \
> - getnetbynm_r \
> - getproto getproto_r getprtent getprtent_r getprtname getprtname_r \
> - getsrvbynm getsrvbynm_r getsrvbypt getsrvbypt_r getservent \
> - getservent_r getrpcent getrpcbyname getrpcbynumber \
> - getrpcent_r getrpcbyname_r getrpcbynumber_r \
> - ether_aton ether_aton_r ether_hton ether_line \
> - ether_ntoa ether_ntoa_r ether_ntoh \
> - rcmd rexec ruserpass bindresvport \
> - getnetgrent_r getnetgrent \
> - getaliasent_r getaliasent getaliasname getaliasname_r \
> - in6_addr getnameinfo if_index ifaddrs inet6_option \
> - getipv4sourcefilter setipv4sourcefilter \
> - getsourcefilter setsourcefilter inet6_opt inet6_rth \
> - inet6_scopeid_pton deadline idna idna_name_classify
> +headers := \
> + $(wildcard arpa/*.h protocols/*.h) \
> + aliases.h \
> + bits/in.h \
> + ifaddrs.h \
> + netinet/ether.h \
> + netinet/icmp6.h \
> + netinet/if_ether.h \
> + netinet/igmp.h \
> + netinet/in.h \
> + netinet/in_systm.h \
> + netinet/ip.h \
> + netinet/ip6.h \
> + netinet/tcp.h \
> + rpc/netdb.h \
> + # headers
> +
> +routines := \
> + bindresvport \
> + deadline \
> + ether_aton \
> + ether_aton_r \
> + ether_hton \
> + ether_line \
> + ether_ntoa \
> + ether_ntoa_r \
> + ether_ntoh \
> + getaliasent \
> + getaliasent_r \
> + getaliasname \
> + getaliasname_r \
> + gethstbyad \
> + gethstbyad_r \
> + gethstbynm \
> + gethstbynm2 \
> + gethstbynm2_r \
> + gethstbynm_r \
> + gethstent \
> + gethstent_r \
> + getipv4sourcefilter \
> + getnameinfo \
> + getnetbyad \
> + getnetbyad_r \
> + getnetbynm \
> + getnetbynm_r \
> + getnetent \
> + getnetent_r \
> + getnetgrent \
> + getnetgrent_r \
> + getproto \
> + getproto_r \
> + getprtent \
> + getprtent_r \
> + getprtname \
> + getprtname_r \
> + getrpcbyname \
> + getrpcbyname_r \
> + getrpcbynumber \
> + getrpcbynumber_r \
> + getrpcent \
> + getrpcent_r \
> + getservent \
> + getservent_r \
> + getsourcefilter \
> + getsrvbynm \
> + getsrvbynm_r \
> + getsrvbypt \
> + getsrvbypt_r \
> + herrno \
> + herrno-loc \
> + htonl \
> + htons \
> + idna \
> + idna_name_classify \
> + if_index \
> + ifaddrs \
> + in6_addr \
> + inet6_opt \
> + inet6_option \
> + inet6_rth \
> + inet6_scopeid_pton \
> + inet_lnaof \
> + inet_mkadr \
> + inet_net \
> + inet_netof \
> + inet_ntoa \
> + rcmd \
> + rexec \
> + ruserpass \
> + setipv4sourcefilter \
> + setsourcefilter \
> + # routines
>
> install-others = $(inst_sysconfdir)/rpc
>
> aux := check_pf check_native ifreq
>
> -tests := htontest test_ifindex tst-ntoa tst-ether_aton tst-network \
> - tst-gethnm test-ifaddrs bug-if1 test-inet6_opt tst-ether_line \
> - tst-getni1 tst-getni2 tst-inet6_rth tst-checks tst-checks-posix \
> - tst-sockaddr test-hnto-types tst-if_index-long
> +tests := \
> + bug-if1 \
> + htontest \
> + test-hnto-types \
> + test-ifaddrs \
> + test-inet6_opt \
> + test_ifindex \
> + tst-checks \
> + tst-checks-posix \
> + tst-ether_aton \
> + tst-ether_line \
> + tst-gethnm \
> + tst-getni1 \
> + tst-getni2 \
> + tst-if_index-long \
> + tst-inet6_rth \
> + tst-network \
> + tst-ntoa \
> + tst-sockaddr \
> + # tests
>
> # tst-deadline must be linked statically so that we can access
> # internal functions.
next prev parent reply other threads:[~2023-10-02 14:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 12:55 [PATCH 00/16] Consolidate NSS functionality into nss subdir Arjun Shankar
2023-10-02 12:55 ` [PATCH 01/16] inet: Rearrange and sort Makefile variables Arjun Shankar
2023-10-02 14:11 ` Siddhesh Poyarekar [this message]
2023-10-02 12:55 ` [PATCH 02/16] nss: " Arjun Shankar
2023-10-02 14:12 ` Siddhesh Poyarekar
2023-10-02 12:55 ` [PATCH 03/16] Remove 'grp' and merge into 'nss' and 'posix' Arjun Shankar
2023-10-19 17:55 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 04/16] Remove 'gshadow' and merge into 'nss' Arjun Shankar
2023-10-19 18:15 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 05/16] Remove 'pwd' " Arjun Shankar
2023-10-19 18:29 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 06/16] Remove 'shadow' " Arjun Shankar
2023-10-19 18:44 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 07/16] Move 'aliases' routines from 'inet' " Arjun Shankar
2023-10-19 19:23 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 08/16] Move 'ethers' " Arjun Shankar
2023-10-19 19:39 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 09/16] Move 'hosts' " Arjun Shankar
2023-10-19 19:53 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 10/16] Move 'netgroup' " Arjun Shankar
2023-10-20 12:00 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 11/16] Move 'networks' " Arjun Shankar
2023-10-20 12:17 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 12/16] Move 'protocols' " Arjun Shankar
2023-10-20 12:32 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 13/16] Move 'rpc' " Arjun Shankar
2023-10-20 12:49 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 14/16] Move 'services' " Arjun Shankar
2023-10-20 13:19 ` Adhemerval Zanella Netto
2023-10-02 12:55 ` [PATCH 15/16] Move getaddrinfo from 'posix' " Arjun Shankar
2023-10-20 13:51 ` Adhemerval Zanella Netto
2023-10-24 21:32 ` Joseph Myers
2023-10-26 10:58 ` Arjun Shankar
2023-10-02 12:55 ` [PATCH 16/16] Move getnameinfo from 'inet' to 'nss' Arjun Shankar
2023-10-20 15:08 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd577aaa-1971-7aa1-f7e6-6a4ac6d46b21@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=arjun@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).