From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
To: Stefan Liebler <stli@linux.vnet.ibm.com>, libc-alpha@sourceware.org
Cc: fweimer@redhat.com, schwab@linux-m68k.org, joseph_myers@mentor.com
Subject: Re: [PATCH v3 5/9] ppc: Use libc_ifunc macro for time, gettimeofday.
Date: Tue, 30 Aug 2016 13:46:00 -0000 [thread overview]
Message-ID: <fd6644c7-e4fa-72f2-a402-01a9e588684b@linux.vnet.ibm.com> (raw)
In-Reply-To: <1472047472-30307-5-git-send-email-stli@linux.vnet.ibm.com>
On 08/24/2016 09:04 AM, Stefan Liebler wrote:
> This patch uses the libc_ifunc_hidden macro to create already existing ifunc functions
> time and gettimeofday on power. This way, the libc_hidden_def macro can be used
> instead of inline assemblies.
> On ppc32, the __GI_* symbols do not target the ifunc symbol and thus the
> redirection construct has to be applied here.
>
> ChangeLog:
>
> * sysdeps/unix/sysv/linux/powerpc/gettimeofday.c (__gettimeofday):
> Use libc_ifunc_hidden and libc_hidden_def macro. Redirect ifunced function
> in header for using it as type for ifunc function because __GI_* symbols
> for ppc32 do not target the ifunc symbols.
> * sysdeps/unix/sysv/linux/powerpc/time.c (time): Likewise.
This patch looks ok to me.
next prev parent reply other threads:[~2016-08-30 13:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 14:05 [PATCH v3 1/9] Add configure check to test if gcc supports attribute ifunc Stefan Liebler
2016-08-24 14:05 ` [PATCH v3 9/9] Use libc_ifunc macro for siglongjmp, longjmp in libpthread Stefan Liebler
2016-10-06 11:59 ` Florian Weimer
2016-08-24 14:05 ` [PATCH v3 8/9] Use libc_ifunc macro for vfork " Stefan Liebler
2016-08-30 12:40 ` Florian Weimer
2016-08-24 14:05 ` [PATCH v3 6/9] Use libc_ifunc macro for clock_* symbols in librt Stefan Liebler
2016-08-30 12:39 ` Florian Weimer
2016-08-24 14:05 ` [PATCH v3 4/9] i386, x86: Use libc_ifunc macro for time, gettimeofday Stefan Liebler
2016-09-29 14:34 ` Andreas Schwab
2016-08-24 14:05 ` [PATCH v3 5/9] ppc: " Stefan Liebler
2016-08-30 13:46 ` Paul E. Murphy [this message]
2016-08-24 14:05 ` [PATCH v3 2/9] Use gcc attribute ifunc in libc_ifunc macro instead of inline assembly due to false debuginfo Stefan Liebler
2016-08-29 20:16 ` Paul E. Murphy
2016-08-30 14:12 ` Stefan Liebler
2016-09-29 18:38 ` Adhemerval Zanella
2016-09-30 13:45 ` Stefan Liebler
2016-10-04 13:14 ` Adhemerval Zanella
2016-08-24 14:05 ` [PATCH v3 3/9] s390: Refactor ifunc resolvers " Stefan Liebler
2016-08-30 12:31 ` Florian Weimer
2016-08-30 14:12 ` Stefan Liebler
2016-08-24 17:02 ` [PATCH v3 7/9] Use libc_ifunc macro for system in libpthread Stefan Liebler
2016-08-30 12:39 ` Florian Weimer
2016-08-29 9:34 ` [PATCH v3 1/9] Add configure check to test if gcc supports attribute ifunc Florian Weimer
2016-08-30 14:12 ` Stefan Liebler
2016-09-05 7:13 ` [PING][PATCH " Stefan Liebler
2016-09-29 13:50 ` Stefan Liebler
2016-10-07 9:19 ` [PATCH " Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd6644c7-e4fa-72f2-a402-01a9e588684b@linux.vnet.ibm.com \
--to=murphyp@linux.vnet.ibm.com \
--cc=fweimer@redhat.com \
--cc=joseph_myers@mentor.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=stli@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).