From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54221 invoked by alias); 30 Aug 2016 13:46:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 54191 invoked by uid 89); 30 Aug 2016 13:46:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy=UD:time.c, time.c, timec, __GI_* X-HELO: mx0a-001b2d01.pphosted.com X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: murphyp@linux.vnet.ibm.com Subject: Re: [PATCH v3 5/9] ppc: Use libc_ifunc macro for time, gettimeofday. To: Stefan Liebler , libc-alpha@sourceware.org References: <1472047472-30307-1-git-send-email-stli@linux.vnet.ibm.com> <1472047472-30307-5-git-send-email-stli@linux.vnet.ibm.com> Cc: fweimer@redhat.com, schwab@linux-m68k.org, joseph_myers@mentor.com From: "Paul E. Murphy" Date: Tue, 30 Aug 2016 13:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1472047472-30307-5-git-send-email-stli@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16083013-0028-0000-0000-0000057A0263 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005674; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000184; SDB=6.00751629; UDB=6.00355270; IPR=6.00524434; BA=6.00004679; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012516; XFM=3.00000011; UTC=2016-08-30 13:46:39 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16083013-0029-0000-0000-00002ECB3E32 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-30_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608300133 X-SW-Source: 2016-08/txt/msg00892.txt.bz2 On 08/24/2016 09:04 AM, Stefan Liebler wrote: > This patch uses the libc_ifunc_hidden macro to create already existing ifunc functions > time and gettimeofday on power. This way, the libc_hidden_def macro can be used > instead of inline assemblies. > On ppc32, the __GI_* symbols do not target the ifunc symbol and thus the > redirection construct has to be applied here. > > ChangeLog: > > * sysdeps/unix/sysv/linux/powerpc/gettimeofday.c (__gettimeofday): > Use libc_ifunc_hidden and libc_hidden_def macro. Redirect ifunced function > in header for using it as type for ifunc function because __GI_* symbols > for ppc32 do not target the ifunc symbols. > * sysdeps/unix/sysv/linux/powerpc/time.c (time): Likewise. This patch looks ok to me.