From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 9DACB385840D for ; Thu, 13 Jan 2022 17:21:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DACB385840D Received: by mail-oi1-x22a.google.com with SMTP id s22so8568632oie.10 for ; Thu, 13 Jan 2022 09:21:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=z9Tgad5YNWWkjE5DE+Wg3MTfe/IEigjEQa9zOTQVSYk=; b=obUCIy4mrpsKXA2S9RX+W8bK/gBp4xFPzojE1ro+qtfbiVMr2adEcSaoFc4HEHQdgD SVBfVKxJKd0N1V3Jr2SUdGspIazy621hxhx9t+vfE6LqcMXfFLP+8SMjwFZa05gt/K2J F7jHlCH52WevUmbXC6HS1bvkhNpYar83Ezi1POeIPuzTgRyj92GGuK5I8YOIZhJCxa8t UtXKs22+o/bmUbhQ1pVJPf3HZfJoyxMbLbaWiPZN5d9XZHwkYpqlMDWbJxssZl0kJJu2 sb5yeHI5bNKGkyT9oZNJXOPhGVjzkuS8XkOaf4RWxgd1GAe4ArATJEhI1cnbT/e+rFOg aRSw== X-Gm-Message-State: AOAM531CofJCt5b75kxHzsDfHM2mjgF4igXsReuUyTr3LsyuifhARbk6 xw6J6GG4fTqAPcuaXsdKIMlf6FcuTfDBgw== X-Google-Smtp-Source: ABdhPJzqhu6r91T0q7MWwuLEFRUY7aUX19Ute8YNXoW1QGeR8uTlwUNzOonFt8R89MldbCffZVRp6g== X-Received: by 2002:a05:6808:1a13:: with SMTP id bk19mr2025761oib.118.1642094514007; Thu, 13 Jan 2022 09:21:54 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:989a:1584:bd83:a167:36ab? ([2804:431:c7cb:989a:1584:bd83:a167:36ab]) by smtp.gmail.com with ESMTPSA id 15sm678269oiy.18.2022.01.13.09.21.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 09:21:53 -0800 (PST) Message-ID: Date: Thu, 13 Jan 2022 14:21:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v6] posix: Add terminal control setting support for posix_spawn Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha Cc: Siddhesh Poyarekar References: <20220113143941.816573-1-adhemerval.zanella@linaro.org> <87v8ynisp4.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87v8ynisp4.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jan 2022 17:21:56 -0000 On 13/01/2022 12:03, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/include/unistd.h b/include/unistd.h >> index 2bcdd494e1..6e71d80015 100644 >> --- a/include/unistd.h >> +++ b/include/unistd.h >> @@ -183,6 +183,10 @@ extern int __truncate (const char *path, __off_t __length); >> extern void *__sbrk (intptr_t __delta); >> libc_hidden_proto (__sbrk) >> >> +extern int __tcsetpgrp (int fd, __pid_t pgrp); >> +libc_hidden_proto (__tcsetpgrp) >> +extern pid_t __getpgrp (void); >> +libc_hidden_proto (__getpgrp); > > Is __getpgrp used anywhere? > > The patch seems to use __getpgid instead. This is a leftover from previous iterations, I will remove it. > >> + /* Trying to set the controlling terminal after a setsid() incurs in a ENOTTY > > No () after function name? Ack. > > Thanks, > Florian >