From: Carlos O'Donell <carlos@redhat.com>
To: caiyinyu <caiyinyu@loongson.cn>, libc-alpha@sourceware.org
Cc: adhemerval.zanella@linaro.org, xry111@xry111.site
Subject: Re: [PATCH] LoongArch: Delete excessively allocated memory.
Date: Mon, 11 Dec 2023 09:08:10 -0500 [thread overview]
Message-ID: <fe17fd5b-eb54-bb82-2b56-ab78aab3726f@redhat.com> (raw)
In-Reply-To: <20231210071058.2947197-1-caiyinyu@loongson.cn>
On 12/10/23 02:10, caiyinyu wrote:
> Backported from glibc 2.39 development.
Backports to non-development branches should be posted to libc-stable@sourceware.org
Backports of non-ABI changing patches are always OK for rolling release branches per project consensus.
> ---
> sysdeps/loongarch/dl-trampoline.h | 68 +++++++++++++++----------------
> 1 file changed, 34 insertions(+), 34 deletions(-)
>
> diff --git a/sysdeps/loongarch/dl-trampoline.h b/sysdeps/loongarch/dl-trampoline.h
> index 02375286f8..99fcacab76 100644
> --- a/sysdeps/loongarch/dl-trampoline.h
> +++ b/sysdeps/loongarch/dl-trampoline.h
> @@ -19,9 +19,9 @@
> /* Assembler veneer called from the PLT header code for lazy loading.
> The PLT header passes its own args in t0-t2. */
> #ifdef USE_LASX
> -# define FRAME_SIZE (-((-9 * SZREG - 8 * SZFREG - 8 * SZXREG) & ALMASK))
> +# define FRAME_SIZE (-((-9 * SZREG - 8 * SZXREG) & ALMASK))
> #elif defined USE_LSX
> -# define FRAME_SIZE (-((-9 * SZREG - 8 * SZFREG - 8 * SZVREG) & ALMASK))
> +# define FRAME_SIZE (-((-9 * SZREG - 8 * SZVREG) & ALMASK))
> #elif !defined __loongarch_soft_float
> # define FRAME_SIZE (-((-9 * SZREG - 8 * SZFREG) & ALMASK))
> #else
> @@ -44,23 +44,23 @@ ENTRY (_dl_runtime_resolve)
> REG_S a7, sp, 8*SZREG
>
> #ifdef USE_LASX
> - xvst xr0, sp, 9*SZREG + 8*SZFREG + 0*SZXREG
> - xvst xr1, sp, 9*SZREG + 8*SZFREG + 1*SZXREG
> - xvst xr2, sp, 9*SZREG + 8*SZFREG + 2*SZXREG
> - xvst xr3, sp, 9*SZREG + 8*SZFREG + 3*SZXREG
> - xvst xr4, sp, 9*SZREG + 8*SZFREG + 4*SZXREG
> - xvst xr5, sp, 9*SZREG + 8*SZFREG + 5*SZXREG
> - xvst xr6, sp, 9*SZREG + 8*SZFREG + 6*SZXREG
> - xvst xr7, sp, 9*SZREG + 8*SZFREG + 7*SZXREG
> + xvst xr0, sp, 9*SZREG + 0*SZXREG
> + xvst xr1, sp, 9*SZREG + 1*SZXREG
> + xvst xr2, sp, 9*SZREG + 2*SZXREG
> + xvst xr3, sp, 9*SZREG + 3*SZXREG
> + xvst xr4, sp, 9*SZREG + 4*SZXREG
> + xvst xr5, sp, 9*SZREG + 5*SZXREG
> + xvst xr6, sp, 9*SZREG + 6*SZXREG
> + xvst xr7, sp, 9*SZREG + 7*SZXREG
> #elif defined USE_LSX
> - vst vr0, sp, 9*SZREG + 8*SZFREG + 0*SZVREG
> - vst vr1, sp, 9*SZREG + 8*SZFREG + 1*SZVREG
> - vst vr2, sp, 9*SZREG + 8*SZFREG + 2*SZVREG
> - vst vr3, sp, 9*SZREG + 8*SZFREG + 3*SZVREG
> - vst vr4, sp, 9*SZREG + 8*SZFREG + 4*SZVREG
> - vst vr5, sp, 9*SZREG + 8*SZFREG + 5*SZVREG
> - vst vr6, sp, 9*SZREG + 8*SZFREG + 6*SZVREG
> - vst vr7, sp, 9*SZREG + 8*SZFREG + 7*SZVREG
> + vst vr0, sp, 9*SZREG + 0*SZVREG
> + vst vr1, sp, 9*SZREG + 1*SZVREG
> + vst vr2, sp, 9*SZREG + 2*SZVREG
> + vst vr3, sp, 9*SZREG + 3*SZVREG
> + vst vr4, sp, 9*SZREG + 4*SZVREG
> + vst vr5, sp, 9*SZREG + 5*SZVREG
> + vst vr6, sp, 9*SZREG + 6*SZVREG
> + vst vr7, sp, 9*SZREG + 7*SZVREG
> #elif !defined __loongarch_soft_float
> FREG_S fa0, sp, 9*SZREG + 0*SZFREG
> FREG_S fa1, sp, 9*SZREG + 1*SZFREG
> @@ -92,23 +92,23 @@ ENTRY (_dl_runtime_resolve)
> REG_L a7, sp, 8*SZREG
>
> #ifdef USE_LASX
> - xvld xr0, sp, 9*SZREG + 8*SZFREG + 0*SZXREG
> - xvld xr1, sp, 9*SZREG + 8*SZFREG + 1*SZXREG
> - xvld xr2, sp, 9*SZREG + 8*SZFREG + 2*SZXREG
> - xvld xr3, sp, 9*SZREG + 8*SZFREG + 3*SZXREG
> - xvld xr4, sp, 9*SZREG + 8*SZFREG + 4*SZXREG
> - xvld xr5, sp, 9*SZREG + 8*SZFREG + 5*SZXREG
> - xvld xr6, sp, 9*SZREG + 8*SZFREG + 6*SZXREG
> - xvld xr7, sp, 9*SZREG + 8*SZFREG + 7*SZXREG
> + xvld xr0, sp, 9*SZREG + 0*SZXREG
> + xvld xr1, sp, 9*SZREG + 1*SZXREG
> + xvld xr2, sp, 9*SZREG + 2*SZXREG
> + xvld xr3, sp, 9*SZREG + 3*SZXREG
> + xvld xr4, sp, 9*SZREG + 4*SZXREG
> + xvld xr5, sp, 9*SZREG + 5*SZXREG
> + xvld xr6, sp, 9*SZREG + 6*SZXREG
> + xvld xr7, sp, 9*SZREG + 7*SZXREG
> #elif defined USE_LSX
> - vld vr0, sp, 9*SZREG + 8*SZFREG + 0*SZVREG
> - vld vr1, sp, 9*SZREG + 8*SZFREG + 1*SZVREG
> - vld vr2, sp, 9*SZREG + 8*SZFREG + 2*SZVREG
> - vld vr3, sp, 9*SZREG + 8*SZFREG + 3*SZVREG
> - vld vr4, sp, 9*SZREG + 8*SZFREG + 4*SZVREG
> - vld vr5, sp, 9*SZREG + 8*SZFREG + 5*SZVREG
> - vld vr6, sp, 9*SZREG + 8*SZFREG + 6*SZVREG
> - vld vr7, sp, 9*SZREG + 8*SZFREG + 7*SZVREG
> + vld vr0, sp, 9*SZREG + 0*SZVREG
> + vld vr1, sp, 9*SZREG + 1*SZVREG
> + vld vr2, sp, 9*SZREG + 2*SZVREG
> + vld vr3, sp, 9*SZREG + 3*SZVREG
> + vld vr4, sp, 9*SZREG + 4*SZVREG
> + vld vr5, sp, 9*SZREG + 5*SZVREG
> + vld vr6, sp, 9*SZREG + 6*SZVREG
> + vld vr7, sp, 9*SZREG + 7*SZVREG
> #elif !defined __loongarch_soft_float
> FREG_L fa0, sp, 9*SZREG + 0*SZFREG
> FREG_L fa1, sp, 9*SZREG + 1*SZFREG
--
Cheers,
Carlos.
prev parent reply other threads:[~2023-12-11 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 7:10 caiyinyu
2023-12-11 14:08 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe17fd5b-eb54-bb82-2b56-ab78aab3726f@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=libc-alpha@sourceware.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).