From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id 0F837385741F for ; Fri, 25 Jun 2021 12:37:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0F837385741F Received: by mail-qk1-x72d.google.com with SMTP id 65so1441466qko.5 for ; Fri, 25 Jun 2021 05:37:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cuCZ1DTFq/fItpZegyw4oChEuBfs2YLVx7X5eQp626E=; b=t5mggxQ2bz9K56h8MKMh4/iJqqs0STVknQ5Vp5J13yLvkuo5McfbCzmo1KTuxto1BK LevC6AvBm6fO7VA8+kDLPwk0FDMBRcDthOKuy4VSiAz6ve8+jjTJTJ4n6VrT7NikNzkf c5+Fvz+vnNVa3OPeQm/9nJEj3eVOzG+i5vuAYpyXC2mXx5yUwjHV5ssBmeGRrbHsIosf Ji9Qyn1QnjqmZbYLjDgzvnhSxnEMGjqLjKdHV++zbd2FLxHlNod6XiuggOm3FItM6rHI uyRrjA885mJV4A4fA6YPlhb+BQ0asS0Kbw7mm36VhJx7sTShWaE7ZMqDDkJEAM3mkvpp E0xw== X-Gm-Message-State: AOAM531QVjwbtuS32hg4Fih/DHBzCrsiHSIY8mts8F+ACwI7cwBnjtD0 TrVEsHdQh0EGwVxIBOHxu669I20CTQqSgw== X-Google-Smtp-Source: ABdhPJzMgS4NH1HS2rvjVp53JgYx86K5E6Tix/s1EqOLQeA4agXJD+AO0swaZexGU0+65hClaZSO8A== X-Received: by 2002:a37:9c4a:: with SMTP id f71mr11383456qke.139.1624624672890; Fri, 25 Jun 2021 05:37:52 -0700 (PDT) Received: from [192.168.1.108] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id y137sm5056483qkb.27.2021.06.25.05.37.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jun 2021 05:37:52 -0700 (PDT) Subject: Re: [COMMITTED] support: Fix xclone build failures on ia64 and hppa To: libc-alpha@sourceware.org References: <87czsaic6v.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Fri, 25 Jun 2021 09:37:51 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87czsaic6v.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jun 2021 12:37:57 -0000 On 25/06/2021 05:24, Florian Weimer via Libc-alpha wrote: > --- > support/xclone.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/support/xclone.c b/support/xclone.c > index 924d2b8754..243eee8b23 100644 > --- a/support/xclone.c > +++ b/support/xclone.c > @@ -30,15 +30,14 @@ xclone (int (*fn) (void *arg), void *arg, void *stack, size_t stack_size, > # ifdef __ia64__ > extern int __clone2 (int (*fn) (void *arg), void *stack, size_t stack_size, > int flags, void *arg, ...); > - r = __clone2 (f, stack, stack_size, flags, arg, /* ptid */ NULL, > - /* tls */ NULL, /* ctid */ ctid); > + r = __clone2 (fn, stack, stack_size, flags, arg, /* ptid */ NULL, > + /* tls */ NULL, /* ctid */ NULL); > # else > # if _STACK_GROWS_DOWN > r = clone (fn, stack + stack_size, flags, arg, /* ptid */ NULL, > /* tls */ NULL, /* ctid */ NULL); > # elif _STACK_GROWS_UP > - r = clone (fn, stack, flags, arg, /* ptid */ NULL, /* tls */ NULL, > - &ctid); > + r = clone (fn, stack, flags, arg, /* ptid */ NULL, /* tls */ NULL, NULL); > # endif > # endif Thanks for catching it.