From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH 03/11] arm: Implement backtrace on top of <unwind-link.h>
Date: Thu, 13 Feb 2020 17:08:00 -0000 [thread overview]
Message-ID: <fea54a97bd5f35a794c44fa7b135d633fa47f9d3.1581613260.git.fweimer@redhat.com> (raw)
In-Reply-To: <cover.1581613260.git.fweimer@redhat.com>
---
sysdeps/arm/backtrace.c | 77 +++++++++++------------------------------
1 file changed, 20 insertions(+), 57 deletions(-)
diff --git a/sysdeps/arm/backtrace.c b/sysdeps/arm/backtrace.c
index ffd3f526b2..893ca39272 100644
--- a/sysdeps/arm/backtrace.c
+++ b/sysdeps/arm/backtrace.c
@@ -17,58 +17,36 @@
License along with the GNU C Library. If not, see
<https://www.gnu.org/licenses/>. */
-#include <libc-lock.h>
-#include <dlfcn.h>
#include <execinfo.h>
#include <stdlib.h>
-#include <unwind.h>
+#include <unwind-link.h>
struct trace_arg
{
void **array;
+ struct unwind_link *unwind_link;
int cnt, size;
};
#ifdef SHARED
-static _Unwind_Reason_Code (*unwind_backtrace) (_Unwind_Trace_Fn, void *);
-static _Unwind_VRS_Result (*unwind_vrs_get) (_Unwind_Context *,
- _Unwind_VRS_RegClass,
- _uw,
- _Unwind_VRS_DataRepresentation,
- void *);
-
-static void *libgcc_handle;
-
-static void
-init (void)
-{
- libgcc_handle = __libc_dlopen ("libgcc_s.so.1");
-
- if (libgcc_handle == NULL)
- return;
-
- unwind_backtrace = __libc_dlsym (libgcc_handle, "_Unwind_Backtrace");
- unwind_vrs_get = __libc_dlsym (libgcc_handle, "_Unwind_VRS_Get");
- if (unwind_vrs_get == NULL)
- unwind_backtrace = NULL;
-}
-
/* This function is identical to "_Unwind_GetGR", except that it uses
"unwind_vrs_get" instead of "_Unwind_VRS_Get". */
static inline _Unwind_Word
-unwind_getgr (_Unwind_Context *context, int regno)
+unwind_getgr (struct unwind_link *unwind_link,
+ _Unwind_Context *context, int regno)
{
_uw val;
- unwind_vrs_get (context, _UVRSC_CORE, regno, _UVRSD_UINT32, &val);
+ UNWIND_LINK_PTR (unwind_link, _Unwind_VRS_Get)
+ (context, _UVRSC_CORE, regno, _UVRSD_UINT32, &val);
return val;
}
/* This macro is identical to the _Unwind_GetIP macro, except that it
uses "unwind_getgr" instead of "_Unwind_GetGR". */
-# define unwind_getip(context) \
- (unwind_getgr (context, 15) & ~(_Unwind_Word)1)
-#else
-# define unwind_backtrace _Unwind_Backtrace
+#define unwind_getip(context) \
+ (unwind_getgr (arg->unwind_link, context, 15) & ~(_Unwind_Word)1)
+
+#else /* !SHARED */
# define unwind_getip _Unwind_GetIP
#endif
@@ -89,20 +67,19 @@ backtrace_helper (struct _Unwind_Context *ctx, void *a)
int
__backtrace (void **array, int size)
{
- struct trace_arg arg = { .array = array, .size = size, .cnt = -1 };
-
- if (size <= 0)
- return 0;
-
-#ifdef SHARED
- __libc_once_define (static, once);
+ struct trace_arg arg =
+ {
+ .array = array,
+ .unwind_link = __libc_unwind_link_get (),
+ .size = size,
+ .cnt = -1
+ };
- __libc_once (once, init);
- if (unwind_backtrace == NULL)
+ if (size <= 0 || arg.unwind_link == NULL)
return 0;
-#endif
- unwind_backtrace (backtrace_helper, &arg);
+ UNWIND_LINK_PTR (arg.unwind_link, _Unwind_Backtrace)
+ (backtrace_helper, &arg);
if (arg.cnt > 1 && arg.array[arg.cnt - 1] == NULL)
--arg.cnt;
@@ -110,17 +87,3 @@ __backtrace (void **array, int size)
}
weak_alias (__backtrace, backtrace)
libc_hidden_def (__backtrace)
-
-
-#ifdef SHARED
-/* Free all resources if necessary. */
-libc_freeres_fn (free_mem)
-{
- unwind_backtrace = NULL;
- if (libgcc_handle != NULL)
- {
- __libc_dlclose (libgcc_handle);
- libgcc_handle = NULL;
- }
-}
-#endif
--
2.24.1
next prev parent reply other threads:[~2020-02-13 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 17:08 [PATCH 00/11] Unify dynamic loading of the libgcc_s unwinder Florian Weimer
2020-02-13 17:08 ` [PATCH 07/11] s390: Implement backtrace on top of <unwind-link.h> Florian Weimer
2020-02-14 11:55 ` Stefan Liebler
2020-02-13 17:08 ` [PATCH 08/11] __frame_state_for: Use <unwind-link.h> for unwinder access Florian Weimer
2020-02-13 17:08 ` [PATCH 09/11] Move sysdeps/gnu/unwind-resume.c to sysdeps/generic/unwind-resume.c Florian Weimer
2020-02-13 17:08 ` [PATCH 06/11] sparc: Implement backtrace on top <unwind-link.h> Florian Weimer
2020-02-13 17:08 ` Florian Weimer [this message]
2020-02-13 17:08 ` [PATCH 05/11] m68k: Implement backtrace on top of <unwind-link.h> Florian Weimer
2020-02-13 17:08 ` [PATCH 11/11] nptl: Use <unwind-link.h> for accessing the libgcc_s unwinder Florian Weimer
2020-02-13 17:08 ` [PATCH 01/11] Implement <unwind-link.h> for dynamically loading " Florian Weimer
2020-02-13 17:08 ` [PATCH 10/11] Implement _Unwind_Resume in libc on top of <unwind-link.h> Florian Weimer
2020-02-13 17:08 ` [PATCH 04/11] i386: Implement backtrace " Florian Weimer
2020-02-13 17:08 ` [PATCH 02/11] backtrace: Implement " Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fea54a97bd5f35a794c44fa7b135d633fa47f9d3.1581613260.git.fweimer@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).