From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Konstantin Kharlamov <Hi-Angel@yandex.ru>, libc-alpha@sourceware.org
Subject: Re: [PATCH] treewide: python-scripts: use `is None` for none-equality
Date: Tue, 20 Feb 2024 10:17:12 -0300 [thread overview]
Message-ID: <fed59fd4-d947-4185-8020-5d30aa15e81b@linaro.org> (raw)
In-Reply-To: <20240218200234.420544-1-Hi-Angel@yandex.ru>
On 18/02/24 17:02, Konstantin Kharlamov wrote:
> Testing for `None`-ness with `==` operator is frowned upon and causes
> warnings in at least "LGTM" python linter. Fix that.
>
> Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> math/gen-tgmath-tests.py | 6 +++---
> nptl/nptl-printers.py | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/math/gen-tgmath-tests.py b/math/gen-tgmath-tests.py
> index 216e4640ef..d3a7f65899 100755
> --- a/math/gen-tgmath-tests.py
> +++ b/math/gen-tgmath-tests.py
> @@ -414,7 +414,7 @@ class Tests(object):
> elif ret == 'g' or 'g' in args:
> # Real and complex.
> have_complex = True
> - if complex_func == None:
> + if complex_func is None:
> complex_func = 'c%s' % func
> # For narrowing macros, compute narrow_args, the list of
> # argument types for which there is an actual corresponding
> @@ -462,7 +462,7 @@ class Tests(object):
> continue
> if t.complex and not have_complex:
> continue
> - if func == None and not t.complex:
> + if func is None and not t.complex:
> continue
> if ret == 's' and t.name.startswith('_Float'):
> continue
> @@ -544,7 +544,7 @@ class Tests(object):
> all_conds.append(can_comb)
> if narrowing:
> all_conds.append(narrow_cond)
> - any_complex = func == None
> + any_complex = func is None
> for t in this_args:
> if t.complex:
> any_complex = True
> diff --git a/nptl/nptl-printers.py b/nptl/nptl-printers.py
> index 41d1a76c65..fc9d39d70c 100644
> --- a/nptl/nptl-printers.py
> +++ b/nptl/nptl-printers.py
> @@ -587,7 +587,7 @@ def register(objfile):
> printer.add_printer('pthread_rwlockattr_t', r'^pthread_rwlockattr_t$',
> RWLockAttributesPrinter)
>
> - if objfile == None:
> + if objfile is None:
> objfile = gdb
>
> gdb.printing.register_pretty_printer(objfile, printer)
next prev parent reply other threads:[~2024-02-20 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 20:02 Konstantin Kharlamov
2024-02-20 13:17 ` Adhemerval Zanella Netto [this message]
2024-02-22 6:30 ` Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed59fd4-d947-4185-8020-5d30aa15e81b@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Hi-Angel@yandex.ru \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).