From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91183-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 114036 invoked by alias); 20 Mar 2018 17:58:15 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 114021 invoked by uid 89); 20 Mar 2018 17:58:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HX-HELO:sk:zimbra.
X-HELO: zimbra.cs.ucla.edu
Subject: Re: Fix signed integer overflow in random_r (bug 17343)
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
References: <alpine.DEB.2.20.1803161732060.20069@digraph.polyomino.org.uk>
 <be4d13fb-ba70-681d-63ce-ba2bed6ead68@cs.ucla.edu>
 <alpine.DEB.2.20.1803201754080.4945@digraph.polyomino.org.uk>
From: Paul Eggert <eggert@cs.ucla.edu>
Message-ID: <fed8c095-c1ba-ee67-525e-5ee8308acd31@cs.ucla.edu>
Date: Tue, 20 Mar 2018 17:58:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1803201754080.4945@digraph.polyomino.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-03/txt/msg00490.txt.bz2

On 03/20/2018 10:54 AM, Joseph Myers wrote:
>         *result = (val >> 1) & 0x7fffffff;

One other thing I just noticed: now that val is uint32_t, the above 
should be simplifed to "*result = val >> 1;". The patch looks good 
otherwise; thanks.