From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7FB333858D28 for ; Mon, 25 Apr 2022 21:58:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7FB333858D28 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-241-aR4je4-hOOiKhkV1MWZFrw-1; Mon, 25 Apr 2022 17:58:57 -0400 X-MC-Unique: aR4je4-hOOiKhkV1MWZFrw-1 Received: by mail-qt1-f199.google.com with SMTP id i3-20020ac813c3000000b002f202d9471dso8735912qtj.15 for ; Mon, 25 Apr 2022 14:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=08Z3lYZsNL7yS7+SXw+IHIpVcxbio3Z7pRzd8Sl8ksA=; b=b0+ZN7gwlEpfwH5HDjqtSe9JA0DH4NGtbyLjMyRbCEDFOxFkxaB+U/ZKTyC6HS9/RI G95VfnZ5ESNXwBm8AAD1HqxkpQInyvCWhxR/IoT3JS7sGaNknEnwjvUNnh4IBp0BNZWQ 7HN/Tgqk2RN6n8+DLBKjtuo4FLQxsRyS2C+yO3qLJuIPIjLv4T8XcEqbj59HhgYUePtw kF9wE7Z+S+uHyLD/SRX7XMbPXIV4Zlw/I0ZlEmpxYC7QIT60RQqNcYLGHmCGkRzOuHTc Oe8eNYSRr79DoiEuxhP6/7LBqsrv2hMyDfCqKPZrErgVb6FpWDGljgLsDnvsr+aU3X2K Bu4A== X-Gm-Message-State: AOAM533KimvCDfYRd52W+zKy11uagwne/gYRL1U2WaMksub7XaBO/pcs YMFy98nMRzkL8mCuTrWYRYygLBGfY3kcOUppDQojCWg8ColmVJ6i5Pe9OpwbrAlo5rG+kN2yDOh fCVDBUbMF5VB1qF4+ELcN X-Received: by 2002:a05:620a:bc8:b0:67a:fe6a:22ac with SMTP id s8-20020a05620a0bc800b0067afe6a22acmr11116393qki.28.1650923936440; Mon, 25 Apr 2022 14:58:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9NAElaM99S2IJ3MLODFeTreNejSTms5RWP/YrQ6aWJOuV3TcAqEqhdROFAQtqpXiQoiKTXg== X-Received: by 2002:a05:620a:bc8:b0:67a:fe6a:22ac with SMTP id s8-20020a05620a0bc800b0067afe6a22acmr11116385qki.28.1650923936214; Mon, 25 Apr 2022 14:58:56 -0700 (PDT) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id i14-20020a05620a248e00b0069f6ab15281sm1372011qkn.52.2022.04.25.14.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 14:58:55 -0700 (PDT) Message-ID: Date: Mon, 25 Apr 2022 17:58:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] INSTALL: Rephrase -with-default-link documentation To: Florian Weimer , libc-alpha@sourceware.org Cc: Andreas Schwab References: <87sfq5s9aj.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <87sfq5s9aj.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 21:58:59 -0000 On 4/22/22 06:27, Florian Weimer via Libc-alpha wrote: LGTM. Double checked --with-default-link (use-default-link=yes) and --without-default-link (use-default-link=no) Reviewed-by: Carlos O'Donell > --- > INSTALL | 8 ++++---- > manual/install.texi | 10 +++++----- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/INSTALL b/INSTALL > index b68884ccd6..237a2f9482 100644 > --- a/INSTALL > +++ b/INSTALL > @@ -90,10 +90,10 @@ if 'CFLAGS' is specified it must enable optimization. For example: > library will still be usable, but functionality may be lost--for > example, you can't build a shared libc with old binutils. > > -'--with-default-link=FLAG' > - With '--with-default-link=yes', the build system does not use a > - custom linker script for linking shared objects. The default for > - FLAG is the opposite, 'no', because the custom linker script is > +'--with-default-link' > + With '--with-default-link', the build system does not use a custom > + linker script for linking shared objects. The default is > + '--without-default-link', because the custom linker script is > needed for full RELRO protection. > > '--with-nonshared-cflags=CFLAGS' > diff --git a/manual/install.texi b/manual/install.texi > index fcfb6901e4..5feccfb6ed 100644 > --- a/manual/install.texi > +++ b/manual/install.texi > @@ -117,11 +117,11 @@ problem and suppress these constructs, so that the library will still be > usable, but functionality may be lost---for example, you can't build a > shared libc with old binutils. > > -@item --with-default-link=@var{FLAG} > -With @code{--with-default-link=yes}, the build system does not use a > -custom linker script for linking shared objects. The default for > -@var{FLAG} is the opposite, @samp{no}, because the custom linker script > -is needed for full RELRO protection. > +@item --with-default-link > +With @code{--with-default-link}, the build system does not use a custom > +linker script for linking shared objects. The default is > +@code{--without-default-link}, because the custom linker script is > +needed for full RELRO protection. > > @item --with-nonshared-cflags=@var{cflags} > Use additional compiler flags @var{cflags} to build the parts of the > -- Cheers, Carlos.