From: "chenzefeng (A)" <chenzefeng2@huawei.com>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"liucheng (G)" <liucheng32@huawei.com>,
Zengweilin <zengweilin@huawei.com>
Subject: RE: [PATCH] malloc: fix memleak in function muntrace
Date: Mon, 20 Apr 2020 13:49:18 +0000 [thread overview]
Message-ID: <ff760289318e48edaf2291eee310935b@huawei.com> (raw)
In-Reply-To: <87wo6b1z7l.fsf@mid.deneb.enyo.de>
* Florian Weimer:
>* chenzefeng:
>> diff --git a/malloc/mtrace.c b/malloc/mtrace.c index
>> 7e7719df97..0b92106e6e 100644
>> --- a/malloc/mtrace.c
>> +++ b/malloc/mtrace.c
>> @@ -365,4 +365,6 @@ muntrace (void)
>>
>> fprintf (f, "= End\n");
>> fclose (f);
>> + if (mtb != NULL)
>> + free (mtb);
>> }
>I don't think this will build. The global variable is called malloc_trace_buffer.
I am sorry, I had not got the correctly patch from local file. I commit it again, thanks for you review.
prev parent reply other threads:[~2020-04-20 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 7:37 chenzefeng
2020-04-19 11:39 ` Florian Weimer
2020-04-20 13:49 ` chenzefeng (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff760289318e48edaf2291eee310935b@huawei.com \
--to=chenzefeng2@huawei.com \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=liucheng32@huawei.com \
--cc=zengweilin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).