From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by sourceware.org (Postfix) with ESMTPS id 9D9C8383E802 for ; Fri, 25 Sep 2020 08:22:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9D9C8383E802 Received: by mail-wm1-x344.google.com with SMTP id l15so1334971wmh.1 for ; Fri, 25 Sep 2020 01:22:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=igRqMh/BmZSAiTmacRc4+NSmjSCbiYvtkvF9kuRBpXI=; b=d8dMlkdpTopHseVfkXmqQ2cAXuZEk5tc4gY++EV0pPmLg3u7vfavZgXUIMm6slwceE f+ySSFnfjZFQhPnJ0qJATygLyztmAc2Su6O2J5fek3+QpghQGCk3CbmCXAViU/XfQigO Nmeyk9IHPQriRKmfxz2A65X+vDzYH5XXUre9ZsJTF21lU0J47l807BtCYOWoeBlTtpbI VVNn1t98is7gW2CnC7XxIwOx6rMsgBgF/38x6YcCppkepk+eYAj7bgdVjzFk9eUobrUg QnQv56eVe2nEG+/0zmFnDoYXtsYg0FS5le9s5vkQ9y4LPC3NU62oh7vdU+xRvOS26qgw WyXA== X-Gm-Message-State: AOAM531xle47sqylO+WLa4hOJ2ltILohuhi23znHAvPsi+H+k3y4PEJG Gfw5pfTd/UQ5W7B9dkOIKOPd+HM9zMLg/A== X-Google-Smtp-Source: ABdhPJxIPgy/TrQAC/Ft4NeTqP1bF9Sh7z+4q2s7izXfr6OdH0Rgd+DCG5EdSMaZ04IZ/YnMYh2DKQ== X-Received: by 2002:a1c:6555:: with SMTP id z82mr1810761wmb.101.1601022160478; Fri, 25 Sep 2020 01:22:40 -0700 (PDT) Received: from [192.168.1.143] ([170.253.60.68]) by smtp.gmail.com with ESMTPSA id 11sm1967612wmi.14.2020.09.25.01.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 01:22:39 -0700 (PDT) Subject: Re: [PATCH 04/10] system_data_types.7: Add float_t To: "Michael Kerrisk (man-pages)" Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org References: <20200925073140.173394-1-colomar.6.4.3@gmail.com> <20200925073140.173394-5-colomar.6.4.3@gmail.com> <5090c977-c75f-66a4-848f-e7ed94510d16@gmail.com> From: Alejandro Colomar Message-ID: Date: Fri, 25 Sep 2020 10:22:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <5090c977-c75f-66a4-848f-e7ed94510d16@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2020 08:22:43 -0000 Hi Michael, On 2020-09-25 10:13, Michael Kerrisk (man-pages) wrote: > Hi Alex, > > A few comments here that also apply for the double_t patch. > Could you revise please? > > On 9/25/20 9:31 AM, Alejandro Colomar wrote: >> +The implementation's most efficient floating type at least as wide as >> +.IR float . > > The C standard is rather terse here. Perhaps we could make the > reader's life a little easier. How about something like: > > [[ > This a type that is intended to be the implementation's > most efficient floating type that is at least as wide as > .IR float . > ]] I removed the "intended" part to simplify it a bit. Do you prefer to keep it? > >> +Its type depends on the value of the macro >> +.BR FLT_EVAL_METHOD : >> +.RS >> +.IP * >> +0; >> +.I float_t >> +is >> +.IR float . >> +.IP * >> +1; >> +.I float_t >> +is >> +.IR double . >> +.IP * >> +2; >> +.I float_t >> +is >> +.IR "long double" . >> +.IP * >> +Other implementation-defined values. >> +.RE > > I think we can format this better as a hanging list. > Something like this: > > [[ > .TP > 0 > .I float_t > is > .IR float . > .TP > 1 > .I float_t > is > .IR double . > .TP > 2 > .I float_t > is > .IR "long double" . > .IP > For other values of > .BR FLT_EVAL_METHOD , > the type of > .I float_t > is implementation-defined. > ] Yes, I wasn't convinced by my formatting. Thanks! I'll fix this patch, and the srcfix that depends on this too. BTW, I'll also add a note that FLT_EVAL_METHOD is defined in Would you add that to "Notes", or as part of the description? > >> +.IP >> +Conforming to: C99 and later; POSIX.1-2001 and later. >> +.IP >> +See also the >> +.I double_t >> +type in this page. >> .\"------------------------------------- gid_t ------------------------/ >> .TP >> .I gid_t > > Thanks, > > Michael > > Thanks, Alex