public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Nathan Phillips <waic9e@protonmail.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Cc: "libc-alpha\\@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] powerpc: Expose VSX feature test
Date: Wed, 28 Mar 2018 13:46:00 -0000	[thread overview]
Message-ID: <lRU70NZseqpysxhqHwztAxvNl3m4T6GRT6NgoQMSS_pidOsSJ8Kjka4tC2ssX-l_IbSu-CYq7H1zHrpHXmOQyb2v6fQE40MDe3dJEsnl27Y=@protonmail.com> (raw)
In-Reply-To: <87r2o42y5f.fsf@linux.ibm.com>

Thank you for reviewing. Well noted about the double spaces.


On March 28, 2018 6:16 AM, Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> wrote:

> Can't you take it directly from the hwcap variable that is already available
> when using libc_ifunc or libc_ifunc_redirected? e.g.
> sysdeps/powerpc/powerpc64/multiarch/memcmp.c

I hadn't seen that, and it makes sense.

The x86 version seems to store everything in cpu_features, then
use that to resolve the ifunc. But I see the pattern is different
in the PPC section.

I propose dropping this patch and I can follow the PPC pattern instead.

      parent reply	other threads:[~2018-03-28 13:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28  8:20 Nathan Phillips
2018-03-28 12:16 ` Tulio Magno Quites Machado Filho
2018-03-28 12:42   ` Adhemerval Zanella
2018-03-28 13:31     ` Tulio Magno Quites Machado Filho
2018-03-28 13:36       ` Adhemerval Zanella
2018-03-28 13:46   ` Nathan Phillips [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='lRU70NZseqpysxhqHwztAxvNl3m4T6GRT6NgoQMSS_pidOsSJ8Kjka4tC2ssX-l_IbSu-CYq7H1zHrpHXmOQyb2v6fQE40MDe3dJEsnl27Y=@protonmail.com' \
    --to=waic9e@protonmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=tuliom@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).