From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109140 invoked by alias); 28 Mar 2018 13:46:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 108934 invoked by uid 89); 28 Mar 2018 13:46:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:645 X-HELO: mail4.protonmail.ch Date: Wed, 28 Mar 2018 13:46:00 -0000 To: Tulio Magno Quites Machado Filho From: Nathan Phillips Cc: "libc-alpha\\@sourceware.org" Reply-To: Nathan Phillips Subject: Re: [PATCH] powerpc: Expose VSX feature test Message-ID: In-Reply-To: <87r2o42y5f.fsf@linux.ibm.com> References: <87r2o42y5f.fsf@linux.ibm.com> Feedback-ID: pIMM7SjgsBkoh1VHiFjtO1aCnt3hdIguBtsk5guUZVvO7OljEshi__TzlKj4CrF76xqm0sJcB-O9Syj4wMI1Lg==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-03/txt/msg00590.txt.bz2 Thank you for reviewing. Well noted about the double spaces. On March 28, 2018 6:16 AM, Tulio Magno Quites Machado Filho wrote: > Can't you take it directly from the hwcap variable that is already availa= ble > when using libc_ifunc or libc_ifunc_redirected? e.g. > sysdeps/powerpc/powerpc64/multiarch/memcmp.c I hadn't seen that, and it makes sense. The x86 version seems to store everything in cpu_features, then use that to resolve the ifunc. But I see the pattern is different in the PPC section. I propose dropping this patch and I can follow the PPC pattern instead.