From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by sourceware.org (Postfix) with ESMTPS id C11CF38582A0 for ; Tue, 16 Aug 2022 14:31:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C11CF38582A0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=fitzsim.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fitzsim.org Received: by mail-qt1-x82f.google.com with SMTP id j17so8209161qtp.12 for ; Tue, 16 Aug 2022 07:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc; bh=l/VMA+gW76Kre+14TvmfpJpEV1HH/syzG/fKBH0L+j0=; b=zdao4qIfgYWnWTMdPq+R+vOquGRBk6+hHZ1ITL454X7FHlaFizWiPMbbIONawPdMxq mLzrkHJ6AZl05/O0zRoqnAWZdpgULzEVkJOOhlZi9e4MO5GpCSLMfpe79tdgHP6/8tpn SvP5+xDVRB46s1zHta4CkKXqUQkt354jMR0P8DZTz5jDFjf0Fwo/B9uqJraefhWv22Qo 9ylE0icflEwJJeIyEmvKtDl/ueSRuoPpBL59GmmK9WIc2wZIQEq5bg/IbspIwcafZ2Z7 NjKhlk1XlLXbhAiZSGO7WMfO+Bck277Rq0Jo4uFDyI0ZRYTxydIf8XeKJYx3sfWYEIQN jqYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc; bh=l/VMA+gW76Kre+14TvmfpJpEV1HH/syzG/fKBH0L+j0=; b=ifPMRLCGMmCz96teQx0uTLVwY6m3NDvcaTotXCe5a8sASbHXNea/S/e6m3b2O7OZ9M rUUBALhpNzbvQX8EUinQeprE0QYGv3sRj0vNZtJ7HybBdNSa26tq3Q/MHgGbQdcIZ99B 0WhCVuEiavk31FZa/AbFgMrrw+w5zbQn9b3AOwIQFNotvd6CAlPB0pCi2echHgU+Dz/9 dkKw2Z17XroldwR7vMDvsQlyZbF2t4WcXc3Ux5T+d2roNgK1yD7WyGw5yghpdeu8BPla 77GRlf+hwcL6XP6CbK1cScWUDRgZMWW6ag5GvtuD50nZvwJB1drCGqKkV9Y774Hk6Omf 2OKw== X-Gm-Message-State: ACgBeo1osrvKCE4HNrR+xYHjJf9yajE2RWeHGM4pQq9H2Ym+1r+ijDg+ SkJJ24B/P2mI83yBXE0tUDYKOy4RztnLaZj8 X-Google-Smtp-Source: AA6agR57+qLjieynmIoHfP8FCraAxJwZ4n96bE0AjO9Vy0TKdC2BznRWmic027OG1Y4R6BMuyseffw== X-Received: by 2002:a05:622a:4806:b0:343:6173:f513 with SMTP id fb6-20020a05622a480600b003436173f513mr17878380qtb.681.1660660301673; Tue, 16 Aug 2022 07:31:41 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id n6-20020a05622a040600b00339b8a5639csm11197644qtx.95.2022.08.16.07.31.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 07:31:40 -0700 (PDT) From: Thomas Fitzsimmons To: Wilco Dijkstra Cc: Florian Weimer , Mark Wielaard , 'GNU C Library' Subject: Re: [PATCH] Improve performance of IO locks References: <878rnoeja2.fsf@oldenburg.str.redhat.com> Date: Tue, 16 Aug 2022 10:31:39 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Tue, 16 Aug 2022 09:18:09 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 14:31:45 -0000 Hi, Thomas Fitzsimmons writes: > Wilco Dijkstra writes: > >>>> I looked at elf/unload as an example; it's segfaulting in >>>> _dl_relocate_object, backtrace attached; not sure what else to check. >>> >>> I don't see this on powerpc64, with a toolchain based on GCC 8.2 and >>> binutils 2.30.=C2=A0 I'm at a loss how these things could be related. >> >> I would not expect the dynamic linker to have changed at all, so one >> option is to check the binary is identical before/after my commit. If >> the dynamic linker somehow got some uses of SINGLE_THREAD_P then that >> might access TLS before it is setup. > > elf/ld64.so.1 is identical before and after your change. > >> The other possibility is that the binary it is trying to link has >> corrupted relocations. It's hard to imagine how that could happen >> unless you use the new GLIBC to link an application and fileio fails >> to write out the data for the relocations. > > I don't know how to check this. I'll contact you off-list to set up > temporary remote access for you. Before setting this up, I checked the system's package list. This builder is running Debian unstable, without unattended upgrades, so some of the toolchain packages were out-of-date. I did an upgrade (388 packages) and the issue seems to have disappeared, so this was likely a toolchain bug that has since been fixed. I have the list of old and new package versions if anyone's interested. Anyway, I think glibc-debian-ppc64 builds will succeed now. Thomas