From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 7F72D3858D37 for ; Fri, 28 Apr 2023 17:50:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F72D3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-63b46186c03so319604b3a.3 for ; Fri, 28 Apr 2023 10:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1682704242; x=1685296242; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=h/+3ZGH1ZMH9W3WEj91aOJjVZq+1o1qaBeHX/UBRVJ8=; b=mwGzPPTW7BPl2ekcnbeaA8Aywz+hGsV4U5f5JikhaS2nJ31Gx/pmbxlLXqkY1M8uzv dX0EPzkXofGjPWeWC18WbZF5ngdp9Jq+pWkZ8It1mEcCkBYdU8L1sQv8HlpSqKdcvIpO 02vtEhc8zlxMGDF07OjNoFh6uNznYSiA4BiiWYUkClVGrtWBp9Mu/hcbhae6odwFRML6 4S15sRHbEMlH4NesYSTEFl4t0sdHhMn1r9dmjhWsb6Q3+TeTqvw5R1pWQmwI7hRXqixt k843yzMrth5VdDATOEcvHQA714MwJA+Nd88ngHP7S8jzNw0YhBSB3JeJecdJzYT+gmDX tdig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682704242; x=1685296242; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h/+3ZGH1ZMH9W3WEj91aOJjVZq+1o1qaBeHX/UBRVJ8=; b=X50+r2FKl4Y2m4MKE8jIb3VCtB7MYeqg0GBJtCYClM3dJVflCdRHmBnYlIiYKEjPzX kqSW2GeTdz/iIFVAgypBUIrN/9biLi2K46sYB0+HnmzNHNuWzpdIFXyhs7U03uDd48vi EcPO8u772TxHoQ4xTh7xmQi0op/3blt+0wFpqqgjDpRmwY0RZ1sTYmrT1gs2tNCDmVxQ 4ZB/92Vu/jlk9vv0sGCWGtt5sCDjwreRkrohqqJ+wL8jLqWrLl13fBHkg7RomFf19eUX osJ6vPbCBMFNCqeg4exQ1loV5UzciiHe3b7kj4Cfv7orzATtzWD4TOpFlbzGn5AYh1RZ Us9Q== X-Gm-Message-State: AC+VfDwJdszJCHMJhgktiD6jTMHtpIoEuEMPFiGjb2TZ3Tyh0GB5xsPt yFh9U/RjUjj1nvwE/IYYYQb1snp+aiIsBbdlkYs= X-Google-Smtp-Source: ACHHUZ7jDVhc5w5cgsyHkX54ZSzkQiwemus7xxjfZxhtmayhT4dbUAxsF2DqnIzWibPYpbVbi1GRwQ== X-Received: by 2002:a05:6a00:2d87:b0:63d:254a:3901 with SMTP id fb7-20020a056a002d8700b0063d254a3901mr9815044pfb.25.1682704242308; Fri, 28 Apr 2023 10:50:42 -0700 (PDT) Received: from localhost ([135.180.227.0]) by smtp.gmail.com with ESMTPSA id g2-20020a62e302000000b0063799398eaesm2083319pfh.51.2023.04.28.10.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 10:50:41 -0700 (PDT) Date: Fri, 28 Apr 2023 10:50:41 -0700 (PDT) X-Google-Original-Date: Fri, 28 Apr 2023 10:50:38 PDT (-0700) Subject: Re: [COMMITTED 1/2] riscv: Resolve symbols directly for symbols with STO_RISCV_VARIANT_CC. In-Reply-To: CC: libc-alpha@sourceware.org, kai.wang@sifive.com, vincent.chen@sifive.com From: Palmer Dabbelt To: joseph@codesourcery.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 28 Apr 2023 10:45:04 PDT (-0700), joseph@codesourcery.com wrote: > How was this tested? I've seeing test failures (for all > build-many-glibcs.py configurations) that look like they were caused by > this patch. > > FAIL: elf/tst-glibcelf > FAIL: elf/tst-relro-ldso > FAIL: elf/tst-relro-libc > > /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:4013: error: macro STO_RISCV_VARIANT_CC redefined > /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:3941: note: location of previous definition > /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:4023: error: macro DT_RISCV_VARIANT_CC redefined > /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:3937: note: location of previous definition > Traceback (most recent call last): > File "/scratch/jmyers/glibc-bot/src/glibc/elf/tst-glibcelf.py", line 23, in > import glibcelf > File "/scratch/jmyers/glibc-bot/src/glibc/scripts/glibcelf.py", line 226, in > _elf_h = _parse_elf_h() > File "/scratch/jmyers/glibc-bot/src/glibc/scripts/glibcelf.py", line 223, in _parse_elf_h > raise IOError('parse error in elf.h') > OSError: parse error in elf.h > > https://sourceware.org/pipermail/libc-testresults/2023q2/011183.html Sorry about that, I'd just committed it because Kito had asked me to a bunch of times (he's trying to sort out commit access). I can just go revert it if you want? Either way I'll go figure out what I screwed up...