From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id DC55A3858C50 for ; Wed, 2 Nov 2022 02:19:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC55A3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x431.google.com with SMTP id z26so2016350pff.1 for ; Tue, 01 Nov 2022 19:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=HHS+Nh3HjHLIxD+3mlFnEYBZe2zk56wnc8KGeiVA7Zk=; b=xsgKILz4XASWLb5Bb6Q7LggHUaT+yHTwe9IYYpllRGaF6gK1FBwSDL/RU+g0cpzCcV C5zFYmH2IvOnfq/THKfhTE0T1jnPkCQds0x7WGiBDP5A/Cy91Ny1Qjzi4VAIVTt5Fopc QJaBgELSki00HA8e5qPXv1AfBF4aKsmX+8kclqRh+O8XRkFhUCJNUSqeWIDftg/uL+GR l48I/o5gc6DPiQ6MhQvs40ee3LadSXU4hHMJtGmST6lXKD5MHOVOPfzWZs4PfLQ+yG1d iQ0yWjKWcs/VZevX/lry/7PfQtKk8Anm47VM/ck/ZQa9YgZRy5gg1qmA74ro2mMiWgHs dQNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HHS+Nh3HjHLIxD+3mlFnEYBZe2zk56wnc8KGeiVA7Zk=; b=F/IVDRBQu93/SFxP/l91sqXK41zpLKgLu2Sb2MnhhLiL8iFg4kT/Um0kjBuJPvya8h TtsIxvA4YLJ5ogZazzzc/g8vfjjfnnjkIp3ZhL7HWtmc7Fkx2ie9LAl8wHCREMTIglDg 9dX5lZWKR7VcUYkO1Zzqkmi3tZP8Z5spzfMhVFSVxExVgImcNaVLd0jupl2SPCjqXzx0 RFUP2Px3TnMMjcRV7MOWioxUPhmqPwzlsURf+88aC7PncEnRosB86hhxDS/ciFZLuT4q ZkLb28ZwpIe8BB2VWst8+uvAPK6RbhfyNty9CkHlBuMrEiJUJWNnLUv9P5Ln68dBKyZm DHDg== X-Gm-Message-State: ACrzQf23Mm7INc0IKfffnznMtdZxM9GlYJrzbUK743yx4JI4RMD6BGiH eASM86NcjqEZuNssRZp8xKrWTQ== X-Google-Smtp-Source: AMsMyM5nTT/H/j2sYMC2oIs8KFrgzGBHjul7nGMkHwwSG6BjKBWFCG2Skdl0bVUgIkEtSZaV5b+QPQ== X-Received: by 2002:a62:7b0f:0:b0:56b:e472:9e81 with SMTP id w15-20020a627b0f000000b0056be4729e81mr22633626pfc.13.1667355598124; Tue, 01 Nov 2022 19:19:58 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id z7-20020aa79587000000b0056bb4bbfb9bsm7373018pfj.95.2022.11.01.19.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 19:19:57 -0700 (PDT) Date: Tue, 01 Nov 2022 19:19:57 -0700 (PDT) X-Google-Original-Date: Tue, 01 Nov 2022 19:19:54 PDT (-0700) Subject: Re: [PATCH] riscv: Get level 3 cache's information In-Reply-To: CC: Darius Rad , Andrew Waterman , dj@redhat.com, joseph@codesourcery.com, schwab@suse.de, libc-alpha@sourceware.org From: Palmer Dabbelt To: zong.li@sifive.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 01 Nov 2022 18:58:46 PDT (-0700), zong.li@sifive.com wrote: > On Fri, Oct 21, 2022 at 3:28 PM Zong Li wrote: >> >> On Fri, Oct 21, 2022 at 3:23 PM Zong Li wrote: >> > >> > RISC-V architecture extends the cache information for level 3 cache >> > in AUX vector in Linux v.6.1-rc1. This patch supports sysconf to get >> > the level 3 cache information. >> > --- >> > sysdeps/unix/sysv/linux/riscv/sysconf.c | 7 +++++++ >> > 1 file changed, 7 insertions(+) >> > >> > diff --git a/sysdeps/unix/sysv/linux/riscv/sysconf.c b/sysdeps/unix/sysv/linux/riscv/sysconf.c >> > index b768ebf781..4772a9fc11 100644 >> > --- a/sysdeps/unix/sysv/linux/riscv/sysconf.c >> > +++ b/sysdeps/unix/sysv/linux/riscv/sysconf.c >> > @@ -90,6 +90,13 @@ __sysconf (int name) >> > return sysconf_get_cache_associativity (AT_L2_CACHEGEOMETRY); >> > case _SC_LEVEL2_CACHE_LINESIZE: >> > return sysconf_get_cache_linesize (AT_L2_CACHEGEOMETRY); >> > + case _SC_LEVEL3_CACHE_SIZE: >> > + return sysconf_get_cache_size (AT_L3_CACHESIZE); >> > + case _SC_LEVEL3_CACHE_ASSOC: >> > + return sysconf_get_cache_associativity (AT_L3_CACHEGEOMETRY); >> > + case _SC_LEVEL3_CACHE_LINESIZE: >> > + return sysconf_get_cache_linesize (AT_L3_CACHEGEOMETRY); >> > + >> > default: >> > return linux_sysconf (name); >> > } >> > -- >> > 2.17.1 >> > > > Hi all, > Because I didn't get any feedback here, could I know whether this > patch is good for all? Are you all willing to help me to pick it up if > it looks good to you? Thanks a lot :) Sorry, for some reason I thought I'd replied to this one. Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Thanks! >> Sorry for missing libc-alpha. Add libc-alpha in this loop.