From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-88578-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 17311 invoked by alias); 24 Dec 2017 00:24:55 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 17296 invoked by uid 89); 24 Dec 2017 00:24:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=HX-Received:10.84.204.136, HContent-Transfer-Encoding:8bit
X-HELO: mail-pl0-f45.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id
         :mime-version:content-transfer-encoding;
        bh=GT9xKjvRDr/4xTbYBjaJBz4u2mOh8rcey+geYcFyVkI=;
        b=hJAO3JEFrlIEg9ej7fzwI/IEVqOZbDIaORXzxAaaaTDefWB1qfJQd7RjPHkx7abobk
         idAEHC3lReWsxkJcqR3Rp6M5E2QR4Fp4pD0LmR/2R4/ENLkgRQGZ1leOAERmz6N9QEBY
         yEzpSV9sOs4QCycwnavq7lBOr2GVhAsIIAsn9vlGsC/PkmCP5ni8XBMHadAgnOvG2clc
         dpGkwWK1bePaBvpi51DXtzqSzJ2xMs/7PAsVfroI/D6yhGJJhZOpeVZOmqHFNe4gOg9X
         yC65CuCAeG2NjSOUm+KaK2ze/SGnBIYuvVt41D6n1D527zk5g6/HoPWdNrpBrDJ0q2r2
         fnfw==
X-Gm-Message-State: AKGB3mKdvAuSR7sBFVO99DslfjYK5AacL8yxRwYiuTScuI6qjYLPrFQD
	8jvn+rc8al3NZ2YL++/5XGukPubqLuQ=
X-Google-Smtp-Source: ACJfBovUq/fLww2T5BydHy+TXetdsst3QVtuRbu+wLo+pwDJyspuHIxph6dhXDAO+HFx4TrIesXBQg==
X-Received: by 10.84.204.136 with SMTP id b8mr18882469ple.319.1514075091738;
        Sat, 23 Dec 2017 16:24:51 -0800 (PST)
Date: Sun, 24 Dec 2017 00:24:00 -0000
X-Google-Original-Date: Sat, 23 Dec 2017 16:08:33 PST (-0800)
Subject:     Re: [PATCH v2 06/15] RISC-V: Generic <math.h> and soft-fp Routines
In-Reply-To: <alpine.DEB.2.20.1712201649110.30469@digraph.polyomino.org.uk>
CC: libc-alpha@sourceware.org, Andrew Waterman <andrew@sifive.com>,
  Darius Rad <darius@bluespec.com>, dj@redhat.com
From: Palmer Dabbelt <palmer@dabbelt.com>
To: joseph@codesourcery.com
Message-ID: <mhng-15bd2023-2b36-40ee-b978-d1c78d3bffe5@palmer-si-x1c4>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SW-Source: 2017-12/txt/msg00878.txt.bz2

On Wed, 20 Dec 2017 08:50:48 PST (-0800), joseph@codesourcery.com wrote:
> On Tue, 19 Dec 2017, Palmer Dabbelt wrote:
>
>> +#ifndef __riscv_flen
>> +
>> +#define _FPU_RESERVED 0xffffffff
>
> Missing preprocessor indentation, "# define" etc. inside #if (except for
> the #if of a header's multiple-include guard).  Likewise generally in lots
> of places in this patch.
>
>> +#define _FCLASS_MINF     (1<<0)
>
> GNU style would use (1 << 0) with spaces around <<; likewise elsewhere in
> this patch.

OK, sorry about that.  I believe I've gotten all of both of these.