From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45843 invoked by alias); 22 Mar 2018 17:43:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 45833 invoked by uid 89); 22 Mar 2018 17:43:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,UPPERCASE_50_75 autolearn=ham version=3.3.2 spammy=H*r:sk:p9-v6so X-HELO: mail-pl0-f45.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=eJgjk1uZNPPYBO3DGQC01bZl9qcwfNLjdZP9sOxxgRk=; b=f95eOzEeyn9+eUzGtf7KMZvA4HSQHSkBXuFYWz1D087LYYlTz2ZiciVM0p8DPWPtP+ vIzYL7IlaMEIYaHY6MvNvtkpv6lW+lg8JTqmqu5yE0usy1TYSlClkRFi/TENOBxmqk8p Y0n14BrLBAbShvtuveapvwa38aLeP0uTpogILJmkNXkIC8rBrk2+jNU+dq7Mc1FmCToh kVBHSrotsWEV8KRtKqJUjnYIjFibTtxx9N97JM84bgu4b0J8mvdgtVZgGgNwkw2faRTd Ur97yzyn6MA48iMt/1o4DiciUdQm6n5v4dVcZT08orIXC/fRpSqkX3zryO4wLfp3I0t/ U8ww== X-Gm-Message-State: AElRT7HArJaRfOLbbwE3zYYa7IUa8whY2I+YT1bv3tgVmbwU9DZ70xjy tcJ+5GUZTkQBP4ACuatBwyktvTYvVDs= X-Google-Smtp-Source: AG47ELs2tfNu7tckwtM1C2eaU+IwRbnQSmRTfgx+d+dxufE0P77gHbtzwItFidsDnxKhmsvvpTdmUA== X-Received: by 2002:a17:902:42e:: with SMTP id 43-v6mr7314049ple.186.1521740600691; Thu, 22 Mar 2018 10:43:20 -0700 (PDT) Date: Thu, 22 Mar 2018 17:43:00 -0000 X-Google-Original-Date: Thu, 22 Mar 2018 10:40:29 PDT (-0700) Subject: Re: [PATCH] RISC-V: add remaining relocations In-Reply-To: CC: libc-alpha@sourceware.org From: Palmer Dabbelt To: schwab@suse.de Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-03/txt/msg00519.txt.bz2 On Thu, 22 Mar 2018 04:34:40 PDT (-0700), schwab@suse.de wrote: > is supposed to be as complete as possible. > > Andreas. > > * elf/elf.h (R_RISCV_BRANCH, R_RISCV_JAL, R_RISCV_CALL) > (R_RISCV_CALL_PLT, R_RISCV_GOT_HI20, R_RISCV_TLS_GOT_HI20) > (R_RISCV_TLS_GD_HI20, R_RISCV_PCREL_HI20, R_RISCV_PCREL_LO12_I) > (R_RISCV_PCREL_LO12_S, R_RISCV_HI20, R_RISCV_LO12_I) > (R_RISCV_LO12_S, R_RISCV_TPREL_HI20, R_RISCV_TPREL_LO12_I) > (R_RISCV_TPREL_LO12_S, R_RISCV_TPREL_ADD, R_RISCV_ADD8) > (R_RISCV_ADD16, R_RISCV_ADD32, R_RISCV_ADD64, R_RISCV_SUB8) > (R_RISCV_SUB16, R_RISCV_SUB32, R_RISCV_SUB64) > (R_RISCV_GNU_VTINHERIT, R_RISCV_GNU_VTENTRY, R_RISCV_ALIGN) > (R_RISCV_RVC_BRANCH, R_RISCV_RVC_JUMP, R_RISCV_RVC_LUI) > (R_RISCV_GPREL_I, R_RISCV_GPREL_S, R_RISCV_TPREL_I) > (R_RISCV_TPREL_S, R_RISCV_RELAX, R_RISCV_SUB6, R_RISCV_SET6) > (R_RISCV_SET8, R_RISCV_SET16, R_RISCV_SET32, R_RISCV_32_PCREL) > (R_RISCV_NUM): Define. > --- > elf/elf.h | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 56 insertions(+), 12 deletions(-) > > diff --git a/elf/elf.h b/elf/elf.h > index 677fccb555..f7748983c8 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -3788,18 +3788,62 @@ enum > #define EF_RISCV_FLOAT_ABI_QUAD 0x0006 > > /* RISC-V relocations. */ > -#define R_RISCV_NONE 0 > -#define R_RISCV_32 1 > -#define R_RISCV_64 2 > -#define R_RISCV_RELATIVE 3 > -#define R_RISCV_COPY 4 > -#define R_RISCV_JUMP_SLOT 5 > -#define R_RISCV_TLS_DTPMOD32 6 > -#define R_RISCV_TLS_DTPMOD64 7 > -#define R_RISCV_TLS_DTPREL32 8 > -#define R_RISCV_TLS_DTPREL64 9 > -#define R_RISCV_TLS_TPREL32 10 > -#define R_RISCV_TLS_TPREL64 11 > +#define R_RISCV_NONE 0 > +#define R_RISCV_32 1 > +#define R_RISCV_64 2 > +#define R_RISCV_RELATIVE 3 > +#define R_RISCV_COPY 4 > +#define R_RISCV_JUMP_SLOT 5 > +#define R_RISCV_TLS_DTPMOD32 6 > +#define R_RISCV_TLS_DTPMOD64 7 > +#define R_RISCV_TLS_DTPREL32 8 > +#define R_RISCV_TLS_DTPREL64 9 > +#define R_RISCV_TLS_TPREL32 10 > +#define R_RISCV_TLS_TPREL64 11 > +#define R_RISCV_BRANCH 16 > +#define R_RISCV_JAL 17 > +#define R_RISCV_CALL 18 > +#define R_RISCV_CALL_PLT 19 > +#define R_RISCV_GOT_HI20 20 > +#define R_RISCV_TLS_GOT_HI20 21 > +#define R_RISCV_TLS_GD_HI20 22 > +#define R_RISCV_PCREL_HI20 23 > +#define R_RISCV_PCREL_LO12_I 24 > +#define R_RISCV_PCREL_LO12_S 25 > +#define R_RISCV_HI20 26 > +#define R_RISCV_LO12_I 27 > +#define R_RISCV_LO12_S 28 > +#define R_RISCV_TPREL_HI20 29 > +#define R_RISCV_TPREL_LO12_I 30 > +#define R_RISCV_TPREL_LO12_S 31 > +#define R_RISCV_TPREL_ADD 32 > +#define R_RISCV_ADD8 33 > +#define R_RISCV_ADD16 34 > +#define R_RISCV_ADD32 35 > +#define R_RISCV_ADD64 36 > +#define R_RISCV_SUB8 37 > +#define R_RISCV_SUB16 38 > +#define R_RISCV_SUB32 39 > +#define R_RISCV_SUB64 40 > +#define R_RISCV_GNU_VTINHERIT 41 > +#define R_RISCV_GNU_VTENTRY 42 > +#define R_RISCV_ALIGN 43 > +#define R_RISCV_RVC_BRANCH 44 > +#define R_RISCV_RVC_JUMP 45 > +#define R_RISCV_RVC_LUI 46 > +#define R_RISCV_GPREL_I 47 > +#define R_RISCV_GPREL_S 48 > +#define R_RISCV_TPREL_I 49 > +#define R_RISCV_TPREL_S 50 > +#define R_RISCV_RELAX 51 > +#define R_RISCV_SUB6 52 > +#define R_RISCV_SET6 53 > +#define R_RISCV_SET8 54 > +#define R_RISCV_SET16 55 > +#define R_RISCV_SET32 56 > +#define R_RISCV_32_PCREL 57 > + > +#define R_RISCV_NUM 58 > > /* BPF specific declarations. */ This looks good to me, I guess we just had the dynamic relocations in our glibc port as they're the only ones that show up, but these are all set in the ABI so it seems sane to expose them. If there's no other comments then I'll commit it. Thanks!