From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id ADACA3858C53 for ; Wed, 13 Mar 2024 00:11:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADACA3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ADACA3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710288679; cv=none; b=WmIw3fsezNsyI25pEvxaUb65+6E0f0+9KqGKWhPkfA1JG71JVlGhNoPDYM04yLmP2wSMUBbQ1yKexvMM82hH+lJ/XrsANjIVev+PB0wruhqRa67h0vfqfOTFIYqlXkSBDnktZkFbz6DlD0sublZUNW/xUmIQnI3LVJvAvBkZwFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710288679; c=relaxed/simple; bh=fXqFo4vp2O17ApbOUS1D7h08Tq8zThnMHK6BmpeU0U4=; h=DKIM-Signature:Date:Subject:From:To:Message-ID:Mime-Version; b=A0azGJWtQddpnxqwQADAmwhL401Ot3r9QMaQ3yHiuENzeQL71jZfYbk+8ZQt5JxgN9B4zCer4NyunsJ1a2jPlEPFiupSUxbevjvPD5TqPpyNIr8vDj0ioQm8hH9fE8NvoRl7wuOCxxgYSbWPXhmogRzmwiOPn3oJSepD9MOEkFE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5c229dabbb6so4436240a12.0 for ; Tue, 12 Mar 2024 17:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1710288676; x=1710893476; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=lqmhZ+6729K64angJDe3mmk27heiYUFyy6JQM7kuwQQ=; b=wsYU2ul6hWn++OK+KRfhor+lgcO4Vz0IIK9JosSLaUvtMMG8FPhgOVH+gRHjL8Q2Ex qRFHDb7fx+x+l66jWqxArO4qJlGy1fHIJ7zT3j8cGwx8A35yxMYotSL46ixF9n6NJSk0 f3Kr1DDAHEdSt0zevdezZ6gkr7uxnQl9WNuKcbF8gqb4p0qUywAjQbgG2Aug22MMl2IC AlLFbkebUGHu2cKU8zmumd9rH3uc1S1NZDzIpjDcOMpxdypl4pcO1RE8NAZErdiQunbu HFwYMilm9ktlafEvAErGQx98LCtmtikgilQiUZBgud2zmk4OSxv7dsGeUTOhtWg6pmGh YkVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710288676; x=1710893476; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lqmhZ+6729K64angJDe3mmk27heiYUFyy6JQM7kuwQQ=; b=tedOztkyfRpcM+jUU0dlh4VNE9LIz5AyxEiQ4HjcLy4M4OqECdgjXTD07cteUmRWqQ f99HBTtJQlPLy/cshGm6043teZLhvrpWDCxrv8g4EvRfVLuV1v8nAAy2wbzIFQDqAKgT Z8l5YybednE/Zh9OEuhNp3B6hqUiVC0w43JLYCY1A4Unm9YqsvOSiAibN1h9Ogecvggf t5iaHrzdXlqxNo1S3No2YC6OWQnfqBAh1fg4Fb+iw80LAGoqiWiVaLsmRj2CdCngioIH 1GvZ+AFYf9/wq5Uo9gSd38NyCjEIJqAfUDhcC6m4Y98aRhyCMydhF0XheoEyG34KPP66 DZxA== X-Forwarded-Encrypted: i=1; AJvYcCXgdBz1O9DshyrscbroOjZJSe8BGQyT+hJg+iX3XHT1+Z7abJmKI0hImkY5zisAenmAIfzYE932AaMZmDfBYJdf0o5Kxirhd1pI X-Gm-Message-State: AOJu0Yyx3Us+JHpz/6/yxPwVQCDds3AebbJNH3EAtWYKD8ZX8sCsg6ZC vhb7oKZ5wN27IwOvCUkjYbTS0HTfdddCtQXGWryooYawiuASozav2CSYhLZal1c= X-Google-Smtp-Source: AGHT+IEliBflleQPz/RrcJfyk5FHAzV8ta7R1aftO6uYYyeQ7k8UJBjNVUZ+d1UvG61l+KFx3K7bXQ== X-Received: by 2002:a05:6a21:3a94:b0:1a1:8c29:6c86 with SMTP id zv20-20020a056a213a9400b001a18c296c86mr3106247pzb.25.1710288676391; Tue, 12 Mar 2024 17:11:16 -0700 (PDT) Received: from localhost ([50.213.54.97]) by smtp.gmail.com with ESMTPSA id z17-20020a170903019100b001dd7d66ac95sm6967944plg.78.2024.03.12.17.11.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 17:11:15 -0700 (PDT) Date: Tue, 12 Mar 2024 17:11:15 -0700 (PDT) X-Google-Original-Date: Tue, 12 Mar 2024 17:10:00 PDT (-0700) Subject: Re: [PATCH] Don't check signatures in build-many-glibcs.py In-Reply-To: CC: simon.chopin@canonical.com, libc-alpha@sourceware.org From: Palmer Dabbelt To: Carlos O'Donell Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 07 Mar 2024 12:44:01 PST (-0800), Carlos O'Donell wrote: > On 3/6/24 05:39, Simon Chopin wrote: >> Hi Palmer, thanks for the patch. >> >> On ven. 12 janv. 2024 10:58:46, Palmer Dabbelt wrote: >>> I sign commits and have signature verification on in git. Maybe that's >>> a bad idea because it trips up a bunch of scripts, but it's pretty easy >>> to just force skipping signature verification here. >> >> Presumably, there's all kind of things that could go wrong if the user >> has some particular git configuration. I feel like this particular can >> of worms could be side-stepped entirely if we just set GIT_CONFIG_GLOBAL >> to /dev/null (and perhaps used GIT_CONFIG_NOSYSTEM=1 for good measure) >> to clear any interfering custom config. > > I agree completely. > > If we need to we should reset tooling *defaults* so bmg runs as expected. Seems reasonable to me. I sent a v2. > >> WDYT? >> >>> >>> Signed-off-by: Palmer Dabbelt >>> --- >>> scripts/build-many-glibcs.py | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py >>> index ec2ded6e56..f9cf14c94d 100755 >>> --- a/scripts/build-many-glibcs.py >>> +++ b/scripts/build-many-glibcs.py >>> @@ -931,7 +931,7 @@ class Context(object): >>> if self.replace_sources: >>> subprocess.run(['git', 'clean', '-dxfq'], >>> cwd=self.component_srcdir(component), check=True) >>> - subprocess.run(['git', 'pull', '-q'], >>> + subprocess.run(['git', 'pull', '-q', '--no-verify-signatures'], >>> cwd=self.component_srcdir(component), check=True) >>> else: >>> if self.shallow: >>> -- >>> 2.43.0 >>> >>