From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 338153858D28 for ; Mon, 1 May 2023 12:42:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 338153858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1a5197f00e9so17809205ad.1 for ; Mon, 01 May 2023 05:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1682944959; x=1685536959; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=aKDhrFz92Kgp/E/XnaoLGi2bhWD9zqz1+Cl16IOZhQE=; b=TSqEuWY5otAx0lYnV3S099vxauK3CjIWvr4WA9YoAwFqQeyqbVHh50qTtnqZrwR2CY Q7m+dl72OxA5qfQ6WcNnA8LUV6rBuMmjRpDZGeeShVzeZ9dN7wKphhIX4+REHVKGdPTk wzap84vC+WDHE7Lkjn7Kf53YGJQOcrKF840BorGA477852BAW0G05ncIYS/TxkGJ420b FLBLXEzPU2DVUoLiGeJadDe1hyRQQ2Z041fkjoF7HoIfQtNP/3qoQ2t6OeEgqHldL8fu NwJP25Eiv+77y4GylM0UvXwdoYdHxUS4/E0ctZLfQGoB5ifeFeTP75epDd9Y6g6yFTHm vlQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682944959; x=1685536959; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aKDhrFz92Kgp/E/XnaoLGi2bhWD9zqz1+Cl16IOZhQE=; b=H1aEvLNVe7axqekumZdcSJsAk65JOpCgW+rEvr/s+8Fqk6BILv2mxrrqwLJKBkd3/s JUD5f3bs/a1NEpqoT4ZAtkKJR/UKIthkfZgFFWu4l6KcBhE/NRgVQmY8QTkvvZm76PKy E9GapzDrKgBiDXQf3/y8bvGfQDcXIOnrEyp1B/2MS51Rpo7XMWKvhyFWPfaBCtj8pkrt 4U0YdXnIwhZFzjc0h/onEZLS7cr2UHV9izf5wcEHkzz/1DGYYs67WF+GV5UroN9YJgTO PO8OK3pEFXgoZZEAIaJjHotYLPcagoseW9p1SrpYcw+5JVd3nCz6Emr0Vlns58+TUNXb GawA== X-Gm-Message-State: AC+VfDzVxtn3CjSul/clCHq+oT92OdbeQy5oHHRhYOAwBVbLacvDIDkA rIjMoqoc02N7Ll4SHpfqUDhURNYjCuI5QVtD0bs= X-Google-Smtp-Source: ACHHUZ74YMFHnITpBy7KVIMrai6g3boEXO5dWcVAu8KlKV1nrilmlhtIV5iS6YfuTfkMACufq5jsHA== X-Received: by 2002:a17:902:e549:b0:19c:a9b8:4349 with SMTP id n9-20020a170902e54900b0019ca9b84349mr15888631plf.32.1682944958822; Mon, 01 May 2023 05:42:38 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id p8-20020a1709026b8800b001a04ff0e2eesm17794909plk.58.2023.05.01.05.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 05:42:38 -0700 (PDT) Date: Mon, 01 May 2023 05:42:38 -0700 (PDT) X-Google-Original-Date: Mon, 01 May 2023 05:42:22 PDT (-0700) Subject: Re: error: macro DT/STO_RISCV_VARIANT_CC redefined In-Reply-To: <20230501084208.2h5k4hleimqmoopf@begin> CC: libc-alpha@sourceware.org, kai.wang@sifive.com, vincent.chen@sifive.com From: Palmer Dabbelt To: samuel.thibault@ens-lyon.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 01 May 2023 01:42:08 PDT (-0700), samuel.thibault@ens-lyon.org wrote: > Also, the kai.wang@sifive.com email address doesn't seem to be working, > the mail server says it doesn't exist... Sorry, it's my fault -- I committed it thinking the test suite had been run, but it hadn't. I've got some WIP, but I found another test suite hook I need last night and I've yet to make sure that's enough as my test box went down. I think we should just go ahead and commit the revert for now? That way we can avoid having other folks be broken while I figure out what's up. > > Samuel Thibault, le lun. 01 mai 2023 10:40:30 +0200, a ecrit: >> Hello, >> >> I'm getting these errors: >> >> FAIL: elf/tst-relro-ldso >> FAIL: elf/tst-relro-libc >> FAIL: elf/tst-glibcelf >> >> /mnt/scratch/sthibault/build-glibc/src/glibc/scripts/../elf/elf.h:4013: error: macro STO_RISCV_VARIANT_CC redefined >> /mnt/scratch/sthibault/build-glibc/src/glibc/scripts/../elf/elf.h:3941: note: location of previous definition >> /mnt/scratch/sthibault/build-glibc/src/glibc/scripts/../elf/elf.h:4023: error: macro DT_RISCV_VARIANT_CC redefined >> /mnt/scratch/sthibault/build-glibc/src/glibc/scripts/../elf/elf.h:3937: note: location of previous definition >> Traceback (most recent call last): >> File "/mnt/scratch/sthibault/build-glibc/src/glibc/elf/tst-relro-symbols.py", line 33, in >> import glibcelf >> File "/mnt/scratch/sthibault/build-glibc/src/glibc/elf/../scripts/glibcelf.py", line 226, in >> _elf_h = _parse_elf_h() >> File "/mnt/scratch/sthibault/build-glibc/src/glibc/elf/../scripts/glibcelf.py", line 223, in _parse_elf_h >> raise IOError('parse error in elf.h') >> OSError: parse error in elf.h >> >> and indeed, elf/elf.h defines STO_RISCV_VARIANT_CC and >> DT_RISCV_VARIANT_CC twice. >> >> This seems to have been introduced by 117e8b341c5c ("riscv: Resolve >> symbols directly for symbols with STO_RISCV_VARIANT_CC.")? >> >> Samuel