From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id 05C033858C31 for ; Wed, 20 Sep 2023 13:36:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 05C033858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-1ba5cda3530so4345281fac.3 for ; Wed, 20 Sep 2023 06:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1695216997; x=1695821797; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=R6FKGRsnAMnhE0BiD0Nt85oN2HSs7BgPOgZpO1Ju2eA=; b=jZNjdk6LrAWLN/LjuxcFztzAcYUdWwYoVv2qimf/hYzSII8NZuA7BxT5k485AWDdnv gbepQ/qmqgrOkKdkMpkBYQ0AteBgyKGCJWMCU6K8n/RbEzjJpQKAawXvPn7lDo0VzkGL FAeENQqULmY+FT3MrYVlVh0wOtB4y611iR1iUaSUtQ0X/HZ/47efmx0lQ0Njp/dOd0Ku h0XPOeSAerkW57TSQ8q4Y5pGdCGMMHGsbWugMsd10fwaUBFL3ThdJz1a6EEcMYzEHw9N F94bsh/aQPW6iDJphtsXWFXeW4ajxpJDAWBfBCrHR2bqk7hulioI6zbvEgYgp3mL3U8A O+OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695216997; x=1695821797; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R6FKGRsnAMnhE0BiD0Nt85oN2HSs7BgPOgZpO1Ju2eA=; b=JVIYVTlACeOj+Ubxdcl1mKN84DRonjrm3uXO8oytwryZebsWCHvufWlpyxVS6Y6M0W QbGa7VbzRO+uHEp908aazZJB79NkS7v3DtgvrAxUByVbLG5vEOnUIGPxh5juDPbab+G4 As4pBFGg0azLRlYUlvjqF8/KLBQJv7jGxTUl30MsO+TrbG4g7l+db/mFWoUwgmXE79nk iALwmls493JoDhwgJM40/qU+MVat4E93QkUDJwx1DaTAHGOqXEB9EjvlFOr+BBmMl/gJ sJUpH1ufUb2m2+nrQNlQWkDl+8xdz4D2YnbWS+7VaLBmZxrnI4QThDbAGRBIDD+Dmge7 GlYg== X-Gm-Message-State: AOJu0Yw5z/P9hq8lcQb6AYT1luZRuek+wjRpR19872F2IYKWHr9khtAQ akmv9VsVYrUNe6EXr01rw4SXtA== X-Google-Smtp-Source: AGHT+IEhO3UQ1V3ORQe5VLYlD08L/imGRpgiSatyKlXtNc36Da20y2vh/P9+u6+pnQpKvD49IEps4A== X-Received: by 2002:a05:6870:c190:b0:1be:ffae:29a3 with SMTP id h16-20020a056870c19000b001beffae29a3mr2880275oad.23.1695216997068; Wed, 20 Sep 2023 06:36:37 -0700 (PDT) Received: from localhost ([51.52.155.79]) by smtp.gmail.com with ESMTPSA id i16-20020aa78b50000000b0068a30f6cf32sm10610299pfd.143.2023.09.20.06.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 06:36:36 -0700 (PDT) Date: Wed, 20 Sep 2023 06:36:36 -0700 (PDT) X-Google-Original-Date: Wed, 20 Sep 2023 06:36:32 PDT (-0700) Subject: Re: [PATCH] RISC-V: Enable static-pie. In-Reply-To: <1d075708-675d-0ad6-e51c-f911f09ee084@linaro.org> CC: yanzhang.wang@intel.com, DJ Delorie , Darius Rad , libc-alpha@sourceware.org From: Palmer Dabbelt To: adhemerval.zanella@linaro.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 11 Sep 2023 09:17:22 PDT (-0700), adhemerval.zanella@linaro.org wrote: > > > On 09/09/23 00:30, Palmer Dabbelt wrote: >> On Fri, 08 Sep 2023 20:17:16 PDT (-0700), yanzhang.wang@intel.com wrote: >>> I took some time to test the master with binfmt_misc and qemu system mode. >>> Both of them can't match the requirements (<= 6 failures). >>> >>> - most of cases with binfmt_misc fail with abort. >> >> QEMU user mode isn't a valid test suite target for glibc, there's lots of failures due to the emulation.  I know it's confusing that riscv-gnu-toolchain uses it, that come up when support was added. >> >>> - most of cases with qemu system fail with timed out. >> >> You can set TIMEOUTFACTOR, qemu-system is a lot slower than hardware. >> >>> And also tested with my risc-v board and still fails 70+ cases and most of >>> them are math accuracy issue. >> >> Which board are you running on? >> >>> So Adhemerval, do you know how to setup the environment to reproduce >>> the <= 6 failures ? Maybe I lost some important steps. Thanks very much :). >> >> +DJ and Darius, who usually report test results.  They've probably got the best idea of how to set things up, but I don't remember this requiring anything fancy. > > For the specific support of static-pie, I expect that qemu-system or even > qemu-user would be a feasible testing platform. You might need some > adjustment if the platform implements some math code in assembly, but > if you filter out the expected failures it should be doable to check > the feature is working as intended. It looks like the HW in question likely has some issues in the FPU, see . We'll have to figure something out (maybe just disable FP until userspace has ack'd that it understands the errata?), but for now it's probably best to just test on QEMU. > However it is hard to filter out if you just specify the number of failure > before/after without breaking down which tests has failed and why (Was is > due timeout due emulation? Was it due missing libstdc++.so/libgcc_s.so > support? Was is math failure due wrong emulation?). > >> >>> >>> Thanks, >>> Yanzhang >>> >>>> -----Original Message----- >>>> From: Adhemerval Zanella Netto >>>> Sent: Tuesday, August 15, 2023 7:46 PM >>>> To: Wang, Yanzhang ; Palmer Dabbelt >>>> ; libc-alpha@sourceware.org >>>> Subject: Re: [PATCH] RISC-V: Enable static-pie. >>>> >>>> >>>> >>>> On 13/08/23 09:20, Wang, Yanzhang via Libc-alpha wrote: >>>> > Hi Palmer, >>>> > >>>> > I have tested the commit(542b110585) with this patch. The results like >>>> > below, >>>> > >>>> > Summary of test results: >>>> >     189 FAIL >>>> >    4328 PASS >>>> >     101 UNSUPPORTED >>>> >      16 XFAIL >>>> >       2 XPASS >>>> > >>>> > And the commit(542b110585)'s results like below, >>>> > >>>> > Summary of test results: >>>> >     189 FAIL >>>> >    4326 PASS >>>> >     101 UNSUPPORTED >>>> >      16 XFAIL >>>> >       2 XPASS >>>> > >>>> > The binutils's commit is 2db20b97f1d and gcc's commit is bf36656a14a. >>>> > >>>> > I use the command make check-glibc-linux in riscv-gnu-toolchain. Not >>>> > sure is that acceptable. >>>> >>>> The riscv reports for 2.38 release [1] list at maximum of 6 FAIL for all >>>> the ABI variants.  The 189 failures you are reporting means that your >>>> environment is either missing some setup (for instance, copying the >>>> libgcc_s.so and libstd++.so on the build folder so C++ and tests that >>>> require pthread_cancel or backtrace works correctly) or it is not >>>> properly configured. >>>> >>>> Please sort this out first, since with that amount of failures is not >>>> straightforward to check whether static-pie is really working as intended. >>>