From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 910203858D20 for ; Wed, 9 Nov 2022 21:11:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 910203858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pj1-x102e.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so3025062pjc.3 for ; Wed, 09 Nov 2022 13:11:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=s6tZg3RdGDRzzbHiv70ZF1F+G9OPWD+Q0iVBD9t8LSs=; b=yrtNeMUeUifvKkh5wuP9ko/FZFWV6rh9Ap5kWIycMtry+Xiw+xHOhwvXTEXWr1f7jZ lrB2LcYSKaVMzXAmJZsWpSPJ+CIUqc9/QSHCVlGp2k3AvdYwOcQ4z5T6gs0Njod3/DKb HebzXl5xzB5jvyCwSDCf+dzEyCXCf+vMMEnx9Cfk2vptUUtn1bdfVcI10zB2FrzB8aUI okjmIYLIVprKmle7aTZSDkjC4u6+ToPK4elcBjQdAArKMvyZJ37+aMU/1+sIHmsXwLiG Wq86SWqI6mLtpXxsbsGFVjxGsJN6VIcTwkZIe6MFFq5UEt4OR5p+GUpRszEERLcZ1FNh Et2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s6tZg3RdGDRzzbHiv70ZF1F+G9OPWD+Q0iVBD9t8LSs=; b=UmAwPKnN3cbvgiC3gkH4VUNprBjUKAic8+MhPR+RNEMa9QcegXIrO/ToaXTkVqrI0J zYz5K/hojg4OJuN7RV2U+gYmdrxOIj5/EdH34X0+HeCKkkSMqFvU6tgK17xjx2Zlb5dv xwc8NKWCOWzm4rZAjRzFZY4X1w87+3WfnN9/Lz2S8VZtjPWiORWK3umYz5WFJYE9GZBz ND8huRNRaQniMKJPHm+FZY+CynkNk81iRwzNMO0NlnNOVsrIrGUxd7uZih/N6qB2sp3b Rzhkstq2H19bL+GslcFEyCXR1CTYzolSFh7kG5YAHl66eVQDbKfHJcL72lJoBLmSNkKk BWfg== X-Gm-Message-State: ACrzQf2NwUd6xcGxpz7vj03c/a3/5nbfDCTj0qrUQjPiv07C5hR47zqa UutbVPmI/aMVt+An4EkpTSHciJ71zZBbAw== X-Google-Smtp-Source: AMsMyM4NMEc6h8URsUSQPfp3g/wnL6aGa59QABAXcWhcM4nMxFufgagTKQE0mosuQ7r0AmRQOjWMRw== X-Received: by 2002:a17:902:f78c:b0:185:3d6a:7576 with SMTP id q12-20020a170902f78c00b001853d6a7576mr62007947pln.86.1668028276580; Wed, 09 Nov 2022 13:11:16 -0800 (PST) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id d1-20020a170902cec100b001887e30b9ddsm7142907plg.257.2022.11.09.13.11.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 13:11:15 -0800 (PST) Date: Wed, 09 Nov 2022 13:11:15 -0800 (PST) X-Google-Original-Date: Wed, 09 Nov 2022 13:11:13 PST (-0800) Subject: Re: [PATCH] riscv: Get level 3 cache's information In-Reply-To: <069cd18d-de9f-3f89-7c93-470627d7ad7d@linaro.org> CC: zong.li@sifive.com, Darius Rad , Andrew Waterman , dj@redhat.com, joseph@codesourcery.com, schwab@suse.de, libc-alpha@sourceware.org From: Palmer Dabbelt To: adhemerval.zanella@linaro.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 09 Nov 2022 06:42:03 PST (-0800), adhemerval.zanella@linaro.org wrote: > > > On 08/11/22 22:12, Zong Li wrote: >> On Wed, Nov 2, 2022 at 10:19 AM Palmer Dabbelt wrote: >>> >>> On Tue, 01 Nov 2022 18:58:46 PDT (-0700), zong.li@sifive.com wrote: >>>> On Fri, Oct 21, 2022 at 3:28 PM Zong Li wrote: >>>>> >>>>> On Fri, Oct 21, 2022 at 3:23 PM Zong Li wrote: >>>>>> >>>>>> RISC-V architecture extends the cache information for level 3 cache >>>>>> in AUX vector in Linux v.6.1-rc1. This patch supports sysconf to get >>>>>> the level 3 cache information. >>>>>> --- >>>>>> sysdeps/unix/sysv/linux/riscv/sysconf.c | 7 +++++++ >>>>>> 1 file changed, 7 insertions(+) >>>>>> >>>>>> diff --git a/sysdeps/unix/sysv/linux/riscv/sysconf.c b/sysdeps/unix/sysv/linux/riscv/sysconf.c >>>>>> index b768ebf781..4772a9fc11 100644 >>>>>> --- a/sysdeps/unix/sysv/linux/riscv/sysconf.c >>>>>> +++ b/sysdeps/unix/sysv/linux/riscv/sysconf.c >>>>>> @@ -90,6 +90,13 @@ __sysconf (int name) >>>>>> return sysconf_get_cache_associativity (AT_L2_CACHEGEOMETRY); >>>>>> case _SC_LEVEL2_CACHE_LINESIZE: >>>>>> return sysconf_get_cache_linesize (AT_L2_CACHEGEOMETRY); >>>>>> + case _SC_LEVEL3_CACHE_SIZE: >>>>>> + return sysconf_get_cache_size (AT_L3_CACHESIZE); >>>>>> + case _SC_LEVEL3_CACHE_ASSOC: >>>>>> + return sysconf_get_cache_associativity (AT_L3_CACHEGEOMETRY); >>>>>> + case _SC_LEVEL3_CACHE_LINESIZE: >>>>>> + return sysconf_get_cache_linesize (AT_L3_CACHEGEOMETRY); >>>>>> + >>>>>> default: >>>>>> return linux_sysconf (name); >>>>>> } >>>>>> -- >>>>>> 2.17.1 >>>>>> >>>> >>>> Hi all, >>>> Because I didn't get any feedback here, could I know whether this >>>> patch is good for all? Are you all willing to help me to pick it up if >>>> it looks good to you? Thanks a lot :) >>> >>> Sorry, for some reason I thought I'd replied to this one. >>> >>> Reviewed-by: Palmer Dabbelt >>> Acked-by: Palmer Dabbelt >>> >>> Thanks! >> >> Hi Palmer, thanks a lot for your review. May I ask who might help me >> to pick up this patch? I couldn't find this patch in master yet. > > I installed it, thanks. Thanks. I'd actually managed to kick off a build yesterday but then forgot about it again (the build was fine).