From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40071 invoked by alias); 26 Jan 2018 16:42:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 40008 invoked by uid 89); 26 Jan 2018 16:42:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=defeat, typoproof, typo-proof X-HELO: mail-pg0-f43.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=uYmrdsTp5mCwgOlZJxANCzdy5nKAVAUjqg53sLuoE3E=; b=S/T0wHTXl3hz/+f35mQlkJIeusePE7ysrWt4pGghNNlxNsGT23zFSx4DszQD2IZoFs yy8D7BcgsbUFUYsGospZ7G8/s2AWLCmeXUEYrnO0+hYspYO0Xc2bS6E4/ut1mGCRaGa1 bzEj/OxtMWNA3HIC02APfx5Jk+Da9GaUPLCtY/qDmnx2wQ9i1kYTSMV0rBwJ7RYOZyf5 2ji7nRgX42Ul80HatBjpyQ1TMsNvweE60lF3XIU+c8VaqkUSbrxs87NcND4WhLymNsI9 EpKo/Tt+49l2MkK0InnxeHSVJEnkd1WQ981wCVsoxJZHZZZ+MjVVT9ktjTDDfPPFgml/ drtQ== X-Gm-Message-State: AKwxyte0VVAekSRcT4YaOQOwsLtEESAW/sBOLJQJTtRWahkJNe5sAA+b 6RIIN/2v3MwxxkpMie6PZ8kOVwWKq30= X-Google-Smtp-Source: AH8x225KwctbaybmWOdvRaPneES1RDuOLA60kmnf9Mgg39G0BZBIyUJ4KIMu1+6RP+qAESX6s6WujQ== X-Received: by 2002:a17:902:2e03:: with SMTP id q3-v6mr5947532plb.362.1516984967314; Fri, 26 Jan 2018 08:42:47 -0800 (PST) Date: Fri, 26 Jan 2018 17:51:00 -0000 X-Google-Original-Date: Fri, 26 Jan 2018 08:42:41 PST (-0800) Subject: Re: RISC-V glibc port, v6 In-Reply-To: CC: libc-alpha@sourceware.org, patches@groups.riscv.org, Andrew Waterman , dj@redhat.com, Darius Rad From: Palmer Dabbelt To: joseph@codesourcery.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-01/txt/msg00935.txt.bz2 On Fri, 26 Jan 2018 04:17:34 PST (-0800), joseph@codesourcery.com wrote: > On Thu, 25 Jan 2018, Palmer Dabbelt wrote: > >> RV64IMAC/LP64 results: >> >> Summary of test results: >> 26 FAIL >> 5551 PASS >> 4 UNRESOLVED >> 18 UNSUPPORTED >> 18 XFAIL >> >> Test output [1]. >> >> Includes ~9 expected cross test failures, ~5 timed out that should pass >> with a longer timeout. There are 3 failures due to rounding mode >> issues, tests that should be ignored due to soft float but are not. I >> will investigate more tomorrow. >> >> [1] http://bluespec.com/tmp/glibc-check-lp64.tar.xz > > I see some warnings in those logs: > > ../sysdeps/riscv/math-tests.h:26:5: warning: "__riscv_flen" is not defined, evaluates to 0 [-Wundef] > #if __riscv_flen == 0 > ^~~~~~~~~~~~ > > (a) You're using --disable-werror to build glibc. Don't do that. It may > defeat the point of some tests (that operate at compile time and don't > test anything at runtime) that rely on errors for compilation warnings. > It may also defeat the rules about typo-proof macro conventions in glibc, > which only work with -Wundef warnings are errors. > > (b) The source line in the error message is not part of the posted patch > series, i.e. these test logs don't seem to correspond to the posted > version of the port. The math-tests.h posted uses "#ifdef __riscv_flen", > twice (which is clearly inverted, you should have "#ifndef __riscv_flen", > twice, so see if using that avoids the rounding mode issues you mention), > not "#if __riscv_flen == 0" Thanks -- I changed that between when Darius ran the test suite (I guess without Werror) and when I ran build-many-glibcs.py, which is why they don't quite match up. I'll fix the reversed polarity for our v7.